-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package extra full
#265
Comments
one alternative to |
Hi @FynnBe I recently did some fix for another package which meant for both native and pyodide, I think the best solution so far is to use the conditional statement. setup(
...,
install_requires=[
...
"ruamel.yaml;platform_system!='Emscripten'", # will be included for native python
],
) See here: pyodide/pyodide#1984 (comment) |
naive question @oeway: is there a way to test the package with pyodide in CI? |
@k-dominik Sure, basically we can install a browser in CI and use that to run a webpage to test pyodide. I was doing this with |
Issue reported by @esgomezm: |
I believe we already have a solution for this using the conditional
requirement in the setup.py file. @Fynn
…On Mon 29 Nov 2021 at 14:36, Constantin Pape ***@***.***> wrote:
Issue reported by @esgomezm <https://github.com/esgomezm>:
The validation command in the doc:
https://github.com/bioimage-io/spec-bioimage-io#bioimageio-spec-validator
does not work as expected.
This is because yaml is not included in the default installation (see
discussions in this issue).
We should also somewhere add a recommendation to use bioimageio.core if
one has access to a full python installation, as this avoids many issues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#265 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADU3SYCTS6UCGLEF3I4VL3UON6XBANCNFSM5GL6HSZQ>
.
|
We had a discussion about adding where/how to add the
ruamel.yaml
dependency, which is already included in thetest
extra. @oeway suggested a new extra:full
test
also includes pytest, tox and mypy. so maybe addingfull
is justified...Originally posted by @FynnBe in #259 (comment)
The text was updated successfully, but these errors were encountered: