Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package extra full #265

Open
FynnBe opened this issue Oct 20, 2021 · 6 comments
Open

package extra full #265

FynnBe opened this issue Oct 20, 2021 · 6 comments
Assignees

Comments

@FynnBe
Copy link
Member

FynnBe commented Oct 20, 2021

We had a discussion about adding where/how to add the ruamel.yaml dependency, which is already included in the test extra. @oeway suggested a new extra: full

test also includes pytest, tox and mypy. so maybe adding full is justified...

Originally posted by @FynnBe in #259 (comment)

@FynnBe
Copy link
Member Author

FynnBe commented Oct 20, 2021

one alternative to full and mentioning it in the README.md would be to mention the optional requirement of ruamel.yaml there instead.

@oeway
Copy link
Contributor

oeway commented Nov 23, 2021

Hi @FynnBe I recently did some fix for another package which meant for both native and pyodide, I think the best solution so far is to use the conditional statement.

setup(
    ...,
    install_requires=[
        ...
        "ruamel.yaml;platform_system!='Emscripten'", # will be included for native python
    ],
)

See here: pyodide/pyodide#1984 (comment)

@k-dominik
Copy link
Member

naive question @oeway: is there a way to test the package with pyodide in CI?

@oeway
Copy link
Contributor

oeway commented Nov 23, 2021

@k-dominik Sure, basically we can install a browser in CI and use that to run a webpage to test pyodide. I was doing this with playwright which also has a python version. This does mean it requires some efforts to set it up.

@constantinpape
Copy link
Collaborator

Issue reported by @esgomezm:
The validation command in the doc: https://github.com/bioimage-io/spec-bioimage-io#bioimageio-spec-validator does not work as expected.
This is because yaml is not included in the default installation (see discussions in this issue).
We should also somewhere add a recommendation to use bioimageio.core if one has access to a full python installation, as this avoids many issues.

@oeway
Copy link
Contributor

oeway commented Nov 29, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants