Create output compatible with MPSProto #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review @standage |
standage
approved these changes
Dec 11, 2023
| if software == "efm" and separate is False: | ||
| if (software == "efm" or software == "mpsproto") and separate is False: |
There was a problem hiding this comment.
Another way of implementing this conditional is if software in ("efm", "mpsproto"):. This is more concise, but I'm not sure it's clearer; in any case, this is more of an FYI and not a suggestion for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option of creating files for use in MPSproto using the sequence bracketed form.