-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split sample SNP evidence files into bins for EFM #58
Conversation
Not sure why this keeps failing the style check- it's passing on my computer. Otherwise, this is ready for review @standage |
With some dependencies, you can get away with setting a minimum version and be compatible with quite a few different software versions. With style checking and autoformatting, the The CI build has black fixed at version 22.6: you'll want to make sure that's what you have in your local environment. If you ever want to upgrade the version, it's probably worth a dedicated PR, and then you'll need to change the CI and your local environment at the same time. If that's not the issue, then we'll call up some real gumshoes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If resetting the black version fixes things, I'll be happy to merge this.
I am trying! I had version 23.3... I'm working on downgrading but Conda doesn't make it easy... |
Now I'm running into this error with black 22.6:
|
Ruh roh, looks like we have a test failure with Python 3.9. It doesn't show details, just a false |
I'll do some troubleshooting |
Previously, an R script was used to split individual sample kintelligence files into 10 bins for use in EFM. Adding this feature into lusSTR.
This PR also fixes a bug when specifying no references for SNP processing.