Update bug fixes for FGA, D13 and D21 loci #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
standage
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Updates to the D13 and D21 loci are clear and straightforward. I'm not going to pretend I have a firm grasp of the custom code for handling FGA locus, but the fact that the code satisfies the test suite instills lots of confidence in the implementation. Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some minor issues found while converting lusSTR into an R package (#44 and #45).
I also created a new flanking annotation output file for the
test_flank_anno()function withintest_suite.py. I don't think this file had been updated since incorporating the new STRait Razor config file settings into lusSTR, so this addresses those.