Made compile with removed alias this in Nullable #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dukc
commented
Aug 30, 2021
| // The existing comment here says "null", but function return type | ||
| // forces reading the value anyway. Bug? | ||
| // -Nix packager | ||
| return consumed_reference_bases2.get; // null |
There was a problem hiding this comment.
I also spotted a potential bug while doing this and left a comment accordingly
PetarKirov
approved these changes
Sep 13, 2021
|
Ping @pjotrp |
|
Thank you, lgtm. |
|
@PetarKirov Huh? How did you end up here 😀? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: I want to update LDC in Nix package repository.
The
alias thisofstd.typecons.Nullablehas been removed and now explicit.gets are required.