Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpha diversity] page specific updates #94

Open
wasade opened this issue Mar 5, 2021 · 8 comments
Open

[Alpha diversity] page specific updates #94

wasade opened this issue Mar 5, 2021 · 8 comments

Comments

@wasade
Copy link
Member

wasade commented Mar 5, 2021

The verbiage like “compute” and “Evolutionary breadth” is very technical sounding and can be simplified. Also reduce the number of times that “compute” is used.

No one understands the chart. Can this be switched to showing histograms? Can the tools on the image be removed? Specific comments:

  • “I think it is a look at US/UK over time with a possible snapshot of my data, maybe?”
  • Add a title to the chart
  • Both Axis need labels
  • More of the paragraph needs to be spent on how to interpret the data and what it means and less on how it was derived. That can be put in the learn more section
  • Not sure about the tools that pop up out of nowhere when you hover and their purpose. Make them stick and explain purpose or remove.
@wasade wasade added this to the Results page revisions milestone Mar 5, 2021
@wasade
Copy link
Member Author

wasade commented Mar 5, 2021

@gwarmstrong, can you take this?

@gwarmstrong
Copy link
Member

What is the priority of this vs. sample highlighting on empress?

Also, it might make more sense for @dhakim87 to do the plotting work since it is all in plotly and I think he is more familiar. I have not actually used it before.

This could probably be split into two issues, one for language fixes and the other for the plotting.

@wasade
Copy link
Member Author

wasade commented Mar 5, 2021

Higher priority. Can the empress stuff be handed to Kalen or Yoshiki?

@wasade
Copy link
Member Author

wasade commented Mar 5, 2021

Additional comments from Justin

- i suggest to hyphenate all instances of alpha-diversity and beta-diversity
- i suggest to replace instances of 'compute' and 'computing' with 'calculate' and 'calculating', for consistency
- i suggest to add axes labels to the figure
- in the plots, i suggest to change 'me' to 'you'

@gwarmstrong
Copy link
Member

Can the empress stuff be handed to Kalen or Yoshiki?

The primary blocker is a new endpoint on the public API that returns a sample's features in a format that matches the the collapsed taxonomy for the empress endpoint.

@wasade
Copy link
Member Author

wasade commented Mar 5, 2021

Okay thanks. It might be nice to get some other developers familiar with modifying that codebase?

@gwarmstrong
Copy link
Member

It might be nice to get some other developers familiar with modifying that codebase?

Agreed. Though I am not sure biocore/microsetta-public-api#100 would be the best starting point for a developer new to the project, since it requires a decent understanding of the code base and the task is a little open ended.

@wasade
Copy link
Member Author

wasade commented Mar 5, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants