Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing Arm platforms to skip existing builds #999

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

aliciaaevans
Copy link
Contributor

When running bulk for linux-aarch64 on CircleCI, all recipes started building, even ones that had not been bumped. The FILTER: not building recipe X because the same number of builds are in channel(s) and it is not forced. message was not present in the log. This is because one place in bioconda-utils was missed when addinglinux-aarch64.

Bioconda-utils gets a dataframe of packages from the bioconda and conda-forge channels and then compares with the list of recipes requested to be built to see if a build already exists for that subdir, version, build number, and build string. Only linux-64, osx-64, and noarch were being considered. (The platform here gets converted to a subdir string which has the -64 suffix.)

After this is merged and released, I will re-enable bulk for CircleCI.

@aliciaaevans aliciaaevans marked this pull request as draft June 6, 2024 14:33
@aliciaaevans
Copy link
Contributor Author

Setting this to draft while I double-check if this will have unwanted side-effects.

@aliciaaevans
Copy link
Contributor Author

I think the other places this affects actually benefit or are unaffected by this change. This is adding rows to the dataframe, not changing the existing linux and osx ones.

@aliciaaevans aliciaaevans marked this pull request as ready for review June 6, 2024 15:19
@aliciaaevans aliciaaevans requested review from daler and mbargull June 6, 2024 15:20
Copy link
Member

@daler daler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand yet how linux gets turned into linux-64 but I guess linux-aarch64 doesn't. But it sounds like you confirmed it's only adding rows (and specifically only the ARM rows), in which case I'm not worried!

@aliciaaevans
Copy link
Contributor Author

I don't understand yet how linux gets turned into linux-64 but I guess linux-aarch64 doesn't. But it sounds like you confirmed it's only adding rows (and specifically only the ARM rows), in which case I'm not worried!

Here for information:

def platform2subdir(platform):
if platform == 'linux':
return 'linux-64'
elif platform == 'linux-aarch64':
return 'linux-aarch64'
elif platform == 'osx':
return 'osx-64'
elif platform == 'osx-arm64':
return 'osx-arm64'
elif platform == 'noarch':
return 'noarch'
else:
raise ValueError(
'Unsupported platform: bioconda only supports linux, linux-aarch64, osx, osx-arm64 and noarch.')

@aliciaaevans aliciaaevans merged commit bbc8758 into master Jun 6, 2024
9 checks passed
@aliciaaevans aliciaaevans deleted the fix-arm-platforms branch June 6, 2024 18:12
aliciaaevans pushed a commit that referenced this pull request Jun 6, 2024
🤖 I have created a release \*beep\* \*boop\*
---
###
[3.3.1](https://www.github.com/bioconda/bioconda-utils/compare/v3.3.0...v3.3.1)
(2024-06-06)


### Bug Fixes

* add missing Arm platforms to skip existing builds
([#999](https://www.github.com/bioconda/bioconda-utils/issues/999))
([bbc8758](https://www.github.com/bioconda/bioconda-utils/commit/bbc87583db660ccabdbd0d6fc4e14a8e9721551d))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants