fix: Pass pkg_format to container-based build #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
fix-pkg_format-build_script_template
branch
from
ed81dee to
20a732e
Compare
mbargull
commented
Jun 2, 2024
| # v0.16.2: this used to have a side effect, calling conda build purge | ||
| # hopefully, it's not actually needed. | ||
| build_conf = utils.load_conda_build_config() | ||
| return build_conf.build_folder |
There was a problem hiding this comment.
.build_folder is actually the .../conda-bld/pkg_.... path if the Config would be initialized for some package pkg -- it just happens to be .../conda-bld/ since the pkg_... part is empty for a Config not created for a certain package/recipe.
The new code has the correct config.croot (which is always only the .../conda-bld part.
mbargull
pushed a commit
that referenced
this pull request
Jun 2, 2024
🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/bioconda/bioconda-utils/compare/v3.1.0...v3.2.0) (2024-06-02) ### Features * Update base-glibc-*-bash images to 3.1 ([#996](https://www.github.com/bioconda/bioconda-utils/issues/996)) ([e7c6ca0](https://www.github.com/bioconda/bioconda-utils/commit/e7c6ca0bf7bf2a0815c694634e45d7dff0aa483a)) ### Bug Fixes * Pass pkg_format to container-based build ([#994](https://www.github.com/bioconda/bioconda-utils/issues/994)) ([e3f23ed](https://www.github.com/bioconda/bioconda-utils/commit/e3f23ed70300d97a8f99c5bace7dbba0f559bd19)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we should be able to switch to
pkg_format: 2(i.e., build.condapackages) via config frombioconda-common.