Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bioconductor improvements #944

Merged
merged 13 commits into from
Mar 9, 2024
Merged

feat: bioconductor improvements #944

merged 13 commits into from
Mar 9, 2024

Conversation

daler
Copy link
Member

@daler daler commented Dec 2, 2023

Some fixes identified when preparing for the Bioconductor 3.18 updates:

run_exports. bioconductor-skeleton now adds run_exports to the recipes it builds. Since it's unclear to what extent all bioconductor developers adhere to semantic versioning, I opted for max_pin="x.x", even in the cases where versions start with 0..

Better build numbers. bioconductor-skeleton update-all-packages will now only modify the build number if it's needed. It checks what's available in the channel. So running the command multiple times (sometimes needed if the update process flakes out partway through) will not keep bumping the build number. This also uses the same check as the linting, which will hopefully reduce the frequency of build number adjustments in bulk.

Fix manual build failure annotation. Allow category & reason to show up in manual build failure yaml via bioconda-utils annotate-build-failures CLI

More flexible dag. bioconda-utils dag now supports globs. So now with bioconda-utils dag --packages bioconductor-* | grep -v INFO > dag.gml and then loading dag.gml into Gephi, you can visually identify which packages should be prioritized for building first. This example sizes nodes by out-degree and labels only those with >125 outgoing edges.

image

And minor stuff. The pinning for bioconductor-data-packages needed a space; there was a build-failure yaml that was empty which crashed osx builds.

bioconda_utils/bioconductor_skeleton.py Outdated Show resolved Hide resolved
@dlaehnemann
Copy link
Member

Also, just to document this, there was a suggestion by @mfansler to run unit tests whenever possible when including run_exports. See here for the reasoning:
bioconda/bioconda-recipes#43905 (comment)

@daler daler merged commit b007d34 into master Mar 9, 2024
9 checks passed
@daler daler deleted the bioconductor-improvements branch March 9, 2024 01:54
daler added a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants