Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Live logs and add option to disable #930

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

aliciaaevans
Copy link
Contributor

@aliciaaevans aliciaaevans commented Oct 27, 2023

  • Enable live logging except when a new --disable-live-logs option is enabled.
  • This will improve troubleshooting of CI builds while having the option to avoid excessive log messages.

@aliciaaevans
Copy link
Contributor Author

Per core meeting today, I'm going to change this to default to live logging.

@aliciaaevans aliciaaevans added WIP and removed WIP labels Nov 1, 2023
@aliciaaevans aliciaaevans changed the title feat: Live log option feat: Enable Live logs and add option to disable Nov 1, 2023
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@bgruening bgruening merged commit 47eaadc into master Nov 2, 2023
11 checks passed
@bgruening bgruening deleted the live-log-option branch November 2, 2023 09:15
bgruening pushed a commit that referenced this pull request Nov 2, 2023
🤖 I have created a release \*beep\* \*boop\*
---
##
[2.8.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.7.0...v2.8.0)
(2023-11-02)


### Features

* Enable Live logs and add option to disable
([#930](https://www.github.com/bioconda/bioconda-utils/issues/930))
([47eaadc](https://www.github.com/bioconda/bioconda-utils/commit/47eaadcd4f0da856733e3fd3170d3451ec9c4b8d))


### Bug Fixes

* try locale C.utf8
([#931](https://www.github.com/bioconda/bioconda-utils/issues/931))
([584fcdd](https://www.github.com/bioconda/bioconda-utils/commit/584fcddd45854b88cdf4af72df0a1ad5cc3c9fcc))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
daler pushed a commit to bioconda/bioconda-common that referenced this pull request Nov 2, 2023
This will help get live logging on builds.

bioconda/bioconda-utils#930
daler pushed a commit that referenced this pull request Nov 25, 2023
Enable live logs for mulled-test.

The `--disable-live-logs` option was added in
#930 but was only for the
build. This will enable live logs for the mulled test.


Draft because it still needs testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants