Add r-ngsplot package #9149
Merged
Add r-ngsplot package #9149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
approved these changes
Jun 5, 2018
mbargull
reviewed
Jun 6, 2018
|
|
||
| build: | ||
| number: 0 | ||
| skip: True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this should hopefully work and provide the base package of ngs.plot as a bioconda package, as requested here and here.
One question regarding the packaging here remains open for me: This is NOT a "real" R package, but instead a bunch of R scripts that are bundled together, so I can't install these e.g. using
R CMD INSTALL --build .similar to a standard CRAN or BIOCONDUCTOR package. I did this with symlinking the respective scripts (all of them!) inbinand that should probably work, however some feedback from @bioconda/core would be great to be sure this is fine for everyone. Happy to do things differently, just nothing on the docs for such a case...Regarding the Databases that come with this, @bgruening suggested using
post-linkscripts. However we don't have a stable URL for these (GDrive only, no versioning): How do I drop these at the Galaxy Servers as you suggested @bgruening ?Thanks!