Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update falco to 1.2.5 #52297

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update falco to 1.2.5 #52297

wants to merge 2 commits into from

Conversation

BiocondaBot
Copy link
Collaborator

Update falco: 1.2.41.2.5

install with bioconda Conda

Info Link or Description
Recipe recipes/falco (click to view/edit other files)
Summary falco is a drop-in C++ implementation of FastQC to assess the quality of sequence reads.

Home | https://github.com/smithlabcode/falco
Releases |
Recipe Maintainer(s) | @andrewdavidsmith, @guilhermesena1
Author | @smithlabcode


This pull request was automatically generated (see docs).

@BiocondaBot BiocondaBot added autobump Automatic Version Update new version labels Nov 22, 2024
@pdimens
Copy link
Contributor

pdimens commented Nov 22, 2024

@andrewdavidsmith can you identify why the macOS build isn't working?

@andrewdavidsmith
Copy link
Contributor

Will do. Can you confirm it's x86 that's the issue? That's the only macOS I have access to rn.

@andrewdavidsmith
Copy link
Contributor

Got it. Hopefully next few hours.

@andrewdavidsmith
Copy link
Contributor

@pdimens Might take some time. I assumed it was the make check step, which fails for me due to different cli for the md5sum command, which I use to validate test output files. But what I'm seeing in the workflow file has drifted a bit from what I originally had and the logs aren't telling me much. There will be some trial-and-error here unless someone else has some insights. If there's anything I need to open up to allow others modify parts of this PR, I'm happy to do that and happy for anyone's help.

@andrewdavidsmith
Copy link
Contributor

@mencian Thanks for this, but it didn't work. I only have gcc and llvm-clang (not darwin-clang) on my mac. I can see that the darwin-clang is used to try and compile, but I can't really debug that. I would try to switch it to gcc. My approach to getting it to work with htslib isn't the same as was put into the meta.yml file, so this is drifting a bit away from what I know. Is it possible to pull in gcc and build with CXX=g++? Thanks for any help -- I'll try to look at other recipes.

@andrewdavidsmith
Copy link
Contributor

In case it helps, this is how I configure to compile falco on my Mac and it should indicate lots about my env:

../configure CPPFLAGS="-I$(brew --prefix)/include" LDFLAGS="-L$(brew --prefix)/lib" CC="gcc-14" CXX="g++-14" --prefix=${HOME}

I think I got all dependencies from Homebrew (zlib, htslib and gcc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump Automatic Version Update new version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants