Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Neptune to v2.0.0 #52205

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Updating Neptune to v2.0.0 #52205

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1796f5
Updating Neptune to v2.0.0
emarinier Nov 19, 2024
6c27705
Merge branch 'master' into neptune
emarinier Nov 19, 2024
6686348
coderabbit syntax suggestion
emarinier Nov 19, 2024
99c55f3
Merge branch 'neptune' of github.com:emarinier/bioconda-recipes into …
emarinier Nov 19, 2024
3028e57
Update meta.yaml
mencian Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions recipes/neptune/meta.yaml → recipes/neptune-signature/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,25 @@
package:
name: neptune
version: 1.2.5
name: neptune-signature
version: 2.0.0

source:
url: https://github.com/phac-nml/neptune/archive/v1.2.5.tar.gz
md5: ed48846deffefe25784c9f8b7db2de6e
url: https://github.com/phac-nml/neptune/archive/refs/tags/v2.0.0.tar.gz
md5: 3fcce144d67c74c7921d3b9e36aedacb

build:
noarch: python
number: 3
number: 0
script: {{ PYTHON }} -m pip install . --ignore-installed --no-deps -vv
run_exports:
- {{ pin_subpackage('neptune-signature', max_pin="x") }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix YAML syntax error and verify run_exports configuration.

The run_exports section is correctly configured for ABI compatibility, but there's a YAML syntax error that needs to be fixed.

Apply this diff to fix the indentation:

  number: 0
  script: {{ PYTHON }} -m pip install . --ignore-installed --no-deps -vv
  run_exports:
-    - {{ pin_subpackage('neptune-signature', max_pin="x") }}
+    - {{ pin_subpackage('neptune-signature', max_pin='x') }}

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools
🪛 yamllint

[error] 12-12: syntax error: expected , but found ''

(syntax)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix YAML syntax and verify run_exports configuration

The run_exports section is a good addition for ABI compatibility, but there's a YAML syntax error in this section.

Apply this fix to correct the YAML syntax:

  number: 0
  script: {{ PYTHON }} -m pip install . --ignore-installed --no-deps -vv
  run_exports:
-    - {{ pin_subpackage('neptune-signature', max_pin="x") }}
+    - {{ pin_subpackage('neptune-signature', max_pin='x') }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
number: 0
script: {{ PYTHON }} -m pip install . --ignore-installed --no-deps -vv
run_exports:
- {{ pin_subpackage('neptune-signature', max_pin="x") }}
number: 0
script: {{ PYTHON }} -m pip install . --ignore-installed --no-deps -vv
run_exports:
- {{ pin_subpackage('neptune-signature', max_pin='x') }}
🧰 Tools
🪛 yamllint

[error] 12-12: syntax error: expected , but found ''

(syntax)


requirements:
host:
- python <3
- python >=3.10
- pip
- setuptools
run:
- python <3
- drmaa
- python >=3.10
- numpy
- scipy
- biopython
Expand Down
0 recipes/neptune/post-link.sh → recipes/neptune-signature/post-link.sh
View file
Open in desktop
File renamed without changes.
Loading