Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ampcombi to v.2.0.1 #52184

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Update ampcombi to v.2.0.1 #52184

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f57132b
update recipe to new v 2.0.1
Darcy220606 Nov 19, 2024
e52acc4
Merge branch 'bioconda:master' into update_ampcombi_2.0.1
Darcy220606 Nov 19, 2024
c481bf8
update code review
Darcy220606 Nov 19, 2024
5db48f6
update pinning - code review
Darcy220606 Nov 19, 2024
8775d72
Merge branch 'master' into update_ampcombi_2.0.1
Darcy220606 Nov 19, 2024
5b55527
fix link url
Darcy220606 Nov 19, 2024
95e08a4
Merge branch 'update_ampcombi_2.0.1' of https://github.com/Darcy22060…
Darcy220606 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions recipes/ampcombi/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{% set name = "AMPcombi" %}
{% set version = "0.2.2" %}
{% set version = "2.0.1" %}

package:
name: "{{ name|lower }}"
version: "{{ version }}"

source:
url: "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz"
sha256: da9a179851a8f2041d05ccd10dd45b58099e84059e2e66a9ee405d1913471b58
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/ampcombi-{{ version }}.tar.gz
sha256: 4bef05aa8433d991b76b81cb2338396c064f2ace5c73642411b2a2467524a0eb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

URL format needs to be updated to match PyPI's official source

The current URL template in meta.yaml doesn't match PyPI's official source URL structure. The package is actually hosted at files.pythonhosted.org, not pypi.org/packages. The URL should be updated to:

url: https://files.pythonhosted.org/packages/a0/d3/66d70da14aaedbbc7ed5282e03f8963c5e17f77d47fa2d9bd6f739d8407c/ampcombi-{{ version }}.tar.gz

The SHA256 checksum 4bef05aa8433d991b76b81cb2338396c064f2ace5c73642411b2a2467524a0eb is correct as it matches one of the official checksums from PyPI.

🔗 Analysis chain

Verify PyPI URL format and checksum

The source URL has changed to use pypi.org instead of pypi.io. While both are valid, let's verify the URL accessibility and checksum.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify package URL and checksum
# Test if URL is accessible and verify checksum

# Construct the URL (using echo to avoid download)
echo "URL to verify: https://pypi.org/packages/source/A/AMPcombi/ampcombi-2.0.1.tar.gz"

# Check if package exists on PyPI
curl -s "https://pypi.org/pypi/AMPcombi/2.0.1/json" | jq -r '.urls[].digests.sha256'

Length of output: 380

Script:

#!/bin/bash
# Let's verify the exact URL format by checking the package info
curl -s "https://pypi.org/pypi/ampcombi/2.0.1/json" | jq -r '.urls[] | select(.packagetype=="sdist") | .url'

# Also get the version from meta.yaml to ensure we're checking the right version
echo "Version from meta.yaml:"
grep "version:" recipes/ampcombi/meta.yaml

Length of output: 364


build:
noarch: python
Expand All @@ -32,9 +32,10 @@ requirements:
- backports.tempfile
- contextlib2
- openpyxl
- numpy ==1.26.4
- jsonschema
- python ==3.11
- diamond ==2.0.15
- colorama ==0.4.6
- mmseqs2 ==15.6f452

test:
Expand Down
Loading