Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Commec #52177

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Update Commec #52177

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3755411
Not working due to some issues with versions of dependencies.
Nov 18, 2024
bf23465
Merge branch 'bioconda:master' into master
MichaelBarnett Nov 19, 2024
95e898d
Upload working commec 0.2.0 recipe
MichaelBarnett Nov 19, 2024
e32ff05
Fixed linting issues, added noarch python, and added space between py…
MichaelBarnett Nov 19, 2024
997c83e
Removed erroneous commented local test path, loosened python version …
MichaelBarnett Nov 19, 2024
a344183
Reverted Python version restriction. 3.12 required.
MichaelBarnett Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 19 additions & 20 deletions recipes/commec/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,44 +1,43 @@
{% set name = "commec" %}
{% set version = "0.1.2" %}
{% set sha256 = "33e99060dca151cb9d5481f47e02f1b5276b2cdf61804e7093f0cfc32bef1188" %}
{% set version = "0.2.0" %}
{% set sha256 = "d2d47a84a04194caca22984097d06d5c737af81a4833aa4f824243ee3c511351" %}

package:
name: "{{ name }}"
version: "{{ version }}"

source:
#path: /root/TestingCommec/common-mechanism-0.2.0/common-mechanism-0.2.0
url: https://github.com/ibbis-screening/common-mechanism/archive/refs/tags/v{{version}}.tar.gz
sha256: {{ sha256 }}

build:
number: 0
noarch: python
script: "{{ PYTHON }} -m pip install . --no-deps --no-build-isolation --no-cache-dir -vvv"
run_exports:
# consider using "x.x.x" rather than "x.x", or "x" considering alpha software and liklihood of change.
- {{ pin_subpackage('commec', max_pin="x.x") }}
- {{ pin_subpackage('commec', max_pin="x.x.x") }}

requirements:
host:
- python >=3.1
- pip >=24
- python=3.12
- pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Consider using a more flexible Python version constraint

The strict Python 3.12 requirement might be unnecessarily restrictive. Consider using a range (e.g., python >=3.8) unless there are specific 3.12 features needed.

-    - python=3.12
+    - python >=3.8
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- python=3.12
- pip
- python >=3.8
- pip

run:
- python >=3.1
# Runtime Python dependencies
- biopython >=1.8
- numpy >=2.0.0
- pandas >=2.2
- pytaxonkit >=0.8
- biopython
- numpy
- pandas
- pytaxonkit
# Runtime non-Python dependencies
- bedtools >=2.31
- bedtools
- blast >=2.16
- emboss >=6.6
- diamond >=0.9
- hmmer >=3.4
- infernal >=1.1
- parallel >=20240722
- perl-list-moreutils >=0.430
- taxonkit >=0.17
- emboss
- diamond >=2.1
- hmmer
- infernal
- parallel
- perl-list-moreutils
- taxonkit
- wget

test:
commands:
Expand Down
Loading