Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mzpaf as requirement for mzSpecLib #52166

Merged
merged 7 commits into from
Nov 19, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
added mzpaf recipe
hechth committed Nov 18, 2024
commit 0340111b1fda57aa188706a5f013d126a80c043a
40 changes: 40 additions & 0 deletions recipes/mzpaf/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{% set name = "mzpaf" %}
{% set version = "0.2.0a0" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/mzpaf-{{ version }}.tar.gz
sha256: dbabb1fe8234a5587b451407c44a3c6bb60e1cfbec48978952708b231b45f6d5

build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0

requirements:
host:
- python
- pip
run:
- python
- pyteomics
Comment on lines +23 to +25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add version constraints for dependencies

Consider adding version constraints:

  1. Specify Python version compatibility range
  2. Add version bounds for pyteomics to ensure compatibility
  run:
-   - python
+   - python >=3.7
-   - pyteomics
+   - pyteomics >=4.0
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run:
- python
- pyteomics
run:
- python >=3.7
- pyteomics >=4.0


test:
imports:
- mzpaf
commands:
- pip check
requires:
- pip

about:
summary: HUPO-PSI Peptide peak annotation format
license: CC-BY-1.0
license_file: LICENSE

extra:
recipe-maintainers:
- hechth