Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update artic to 1.5.1 #52092

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Update artic to 1.5.1 #52092

merged 8 commits into from
Nov 13, 2024

Conversation

BiocondaBot
Copy link
Collaborator

Update artic: 1.2.41.5.1

install with bioconda Conda

Info Link or Description
Recipe recipes/artic (click to view/edit other files)
Summary ARTIC pipeline - a bioinformatics pipeline for working with virus sequencing data sequenced with nanopore
Home https://github.com/artic-network/fieldbioinformatics
Releases https://github.com/artic-network/fieldbioinformatics/tags
Author @artic-network

This pull request was automatically generated (see docs).

@BiocondaBot BiocondaBot added autobump Automatic Version Update new version labels Nov 13, 2024
Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

📝 Walkthrough

Walkthrough

This pull request updates the meta.yaml file for the artic package. The version has been changed from 1.2.4 to 1.5.1, and the SHA256 checksum has been updated from 981219a49cec01dc82a9375b16f844278e797ad4034efa1eaa410ccb1849c617 to 6bbd5f07f1417ff046bdc17c57cf55871027738e082121e24c5b22593351d27b. The build number has been modified from 1 to 0. The source URL has been updated to reflect the new version, changing from https://github.com/artic-network/fieldbioinformatics/archive/v1.2.4.tar.gz to https://github.com/artic-network/fieldbioinformatics/archive/v1.5.1.tar.gz. The requirements section has been updated to specify the Python version as ==3.9, and the dependencies artic-porechop and medaka have been removed, with muscle constrained to <5.1. Additionally, clair3 has been added to the run requirements, and cyvcf2 has replaced pyvcf. New entry points have been added, including artic_get_models=artic.get_models:main, and the test commands section has been updated accordingly.

Possibly related PRs

  • Update panaroo to 1.5.1 #51189: The changes in this PR involve updating the version and SHA256 checksum in the meta.yaml file for the panaroo package, similar to the version and checksum updates in the main PR for the artic package.
  • Update slow5tools to 1.3.0 #51048: This PR also updates the version and SHA256 checksum in the meta.yaml file for the slow5tools package, reflecting a similar type of change as seen in the main PR.
  • Update vitap to 1.7 #51215: This PR updates the version and SHA256 checksum in the meta.yaml file for the vitap package, paralleling the version update process in the main PR.
  • Update bactopia-py to 1.3.0 #51466: The changes in this PR include updating the version and SHA256 checksum in the meta.yaml file for the bactopia-py package, which aligns with the versioning updates in the main PR.

Suggested reviewers

  • druvus: Suggested reviewer for the changes made in the meta.yaml file for the artic package.
  • bgruening: Suggested reviewer for the updates in the meta.yaml file for the artic package.

Warning

Rate limit exceeded

@BioWilko has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ddc82d1 and ea1659a.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ddc82d1 and ea1659a.

📒 Files selected for processing (1)
  • recipes/artic/meta.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • recipes/artic/meta.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

📝 Walkthrough

Walkthrough

The pull request introduces updates to the meta.yaml file for the artic package. The version number has been changed from 1.2.4 to 1.5.1, and the SHA256 checksum has been updated accordingly from 981219a49cec01dc82a9375b16f844278e797ad4034efa1eaa410ccb1849c617 to f0917dac3707a664f5447d9bf5a2358a73def64ed6e0e96859cb5e02fefc8791. Additionally, the build number has been modified from 1 to 0. The source URL has been updated to point to the new version, changing from https://github.com/artic-network/fieldbioinformatics/archive/v1.2.4.tar.gz to https://github.com/artic-network/fieldbioinformatics/archive/v1.5.1.tar.gz. The requirements section remains mostly unchanged, although there is a specific comment regarding the pyfaidx package, indicating that its version should not be altered to maintain pipeline functionality. The entry points for the package, which define the command-line interfaces, have not been modified, ensuring that the package's functionality remains intact despite the version upgrade.

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 80a6ddc and 74e6bd2.

📒 Files selected for processing (1)
  • recipes/artic/meta.yaml (2 hunks)
🔇 Additional comments (3)
recipes/artic/meta.yaml (3)

13-13: LGTM: Build number reset is correct

The build number has been correctly reset to 0 for the new version.


Line range hint 31-57: Verify dependency compatibility with new version

The package has several version-specific dependencies. Please verify:

  1. The critical pin on pyfaidx=0.6.0 is still required for v1.5.1
  2. The minimum versions for medaka >=1.10.0 and minimap2 >=2.26 are still appropriate
🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


2-3: Verify version bump and checksum

The version bump from 1.2.4 to 1.5.1 is significant. Let's verify the release and checksum.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
recipes/artic/meta.yaml (2)

38-38: Consider using a more flexible Python version constraint

The Python version is strictly pinned to 3.9, which might be unnecessarily restrictive. Consider using a more flexible version constraint (e.g., >=3.9,<4.0) unless there's a specific reason for this exact version.


53-53: Critical version pin for pyfaidx

The comment indicates this is a critical version pin that should not be changed as it will break the pipeline. Ensure this is documented in the package's documentation or README.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 387ae50 and 59bd96d.

📒 Files selected for processing (1)
  • recipes/artic/meta.yaml (4 hunks)
🔇 Additional comments (4)
recipes/artic/meta.yaml (4)

Line range hint 13-31: LGTM! Build configuration changes look good

  • Build number correctly reset to 0 for the new version
  • New entry point artic_get_models properly added with corresponding test command

72-72: LGTM! Test command properly added

The new test command for artic_get_models is correctly added, maintaining consistency with other entry points.


2-3: Verify SHA256 checksum of the source tarball

The version update to 1.5.1 matches the PR objectives. Let's verify the SHA256 checksum.


42-42: Verify compatibility of major dependency changes

Significant changes in dependencies:

  • Added: clair3
  • Updated: muscle <5.1
  • Replaced: pyvcf with cyvcf2
  • Removed: artic-porechop and medaka

These changes might impact functionality.

Also applies to: 47-47, 52-52

@BioWilko BioWilko enabled auto-merge (squash) November 13, 2024 16:06
Copy link
Contributor

@BioWilko BioWilko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine

@BioWilko BioWilko merged commit 9a6e954 into master Nov 13, 2024
6 checks passed
@BioWilko BioWilko deleted the bump/artic branch November 13, 2024 16:07
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump Automatic Version Update new version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants