-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update artic to 1.5.1 #52092
Update artic to 1.5.1 #52092
Conversation
📝 WalkthroughWalkthroughThis pull request updates the Possibly related PRs
Suggested reviewers
Warning Rate limit exceeded@BioWilko has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 5 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
📝 WalkthroughWalkthroughThe pull request introduces updates to the Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (3)recipes/artic/meta.yaml (3)
The build number has been correctly reset to 0 for the new version. Line range hint The package has several version-specific dependencies. Please verify:
🧰 Tools🪛 yamllint[error] 1-1: syntax error: found character '%' that cannot start any token (syntax)
The version bump from 1.2.4 to 1.5.1 is significant. Let's verify the release and checksum. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/artic/meta.yaml (2)
38-38
: Consider using a more flexible Python version constraintThe Python version is strictly pinned to 3.9, which might be unnecessarily restrictive. Consider using a more flexible version constraint (e.g.,
>=3.9,<4.0
) unless there's a specific reason for this exact version.
53-53
: Critical version pin for pyfaidxThe comment indicates this is a critical version pin that should not be changed as it will break the pipeline. Ensure this is documented in the package's documentation or README.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/artic/meta.yaml
(4 hunks)
🔇 Additional comments (4)
recipes/artic/meta.yaml (4)
Line range hint 13-31
: LGTM! Build configuration changes look good
- Build number correctly reset to 0 for the new version
- New entry point
artic_get_models
properly added with corresponding test command
72-72
: LGTM! Test command properly added
The new test command for artic_get_models
is correctly added, maintaining consistency with other entry points.
2-3
: Verify SHA256 checksum of the source tarball
The version update to 1.5.1 matches the PR objectives. Let's verify the SHA256 checksum.
42-42
: Verify compatibility of major dependency changes
Significant changes in dependencies:
- Added:
clair3
- Updated:
muscle <5.1
- Replaced:
pyvcf
withcyvcf2
- Removed:
artic-porechop
andmedaka
These changes might impact functionality.
Also applies to: 47-47, 52-52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine
Update
artic
: 1.2.4 → 1.5.1recipes/artic
(click to view/edit other files)@artic-network
This pull request was automatically generated (see docs).