-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update regenie to 4.0 #52002
Update regenie to 4.0 #52002
Conversation
📝 WalkthroughWalkthroughThe pull request involves updates to the Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/regenie/meta.yaml
(1 hunks)
🔇 Additional comments (2)
recipes/regenie/meta.yaml (2)
Line range hint 31-31
: Review patch compatibility with v4.0.
The patch 0015-update-cmakelist.txt-for-v3.6.patch
is specifically designed for v3.6. Applying this patch to v4.0 might cause compatibility issues since this is a major version upgrade. Please verify if:
- This patch is still necessary for v4.0
- The patch applies cleanly to v4.0
- A new version-specific patch should be created instead
#!/bin/bash
# Description: Check if the v3.6 patch applies cleanly to v4.0
# Expected: Should show if there are any conflicts
# Download v4.0 source
curl -sL https://github.com/rgcgithub/regenie/archive/v4.0.tar.gz | tar xz
# Check if the patch applies cleanly (assuming patch is in patches directory)
cd regenie-4.0
patch -p1 --dry-run < ../recipes/regenie/patches/0015-update-cmakelist.txt-for-v3.6.patch
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
Line range hint 35-57
: Verify dependency requirements for v4.0.
Please ensure that:
- All dependencies are still compatible with v4.0
- No new dependencies were introduced in v4.0
- The specific version constraints (e.g., boost-cpp 1.74, mkl >=2020.4) are still appropriate
#!/bin/bash
# Description: Check for any dependency changes in v4.0
# Expected: Should show any new or modified dependencies in CMakeLists.txt
# Search for dependency-related changes in CMakeLists.txt
rg -i "find_package|find_library|requires" regenie-4.0/CMakeLists.txt
# Check if README mentions any new dependencies
rg -i "requirement|depend" regenie-4.0/README.md
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
{% set version = "4.0" %} | ||
{% set sha256 = "8f678d55bccf18ab70680637aca3cfd737060b3da291c803f3016d2ac3a07ccf" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Patch 0015 needs to be removed for v4.0
The patch 0015-update-cmakelist.txt-for-v3.6.patch
was specifically designed for v3.6 and should not be applied to v4.0 as:
- The patch header explicitly states it's for v3.6: "update cmakelist file for v3.6"
- v4.0 is a major version update that likely includes its own CMake build system improvements
- Applying v3.6-specific patches to v4.0 could lead to build failures or unexpected behavior
🔗 Analysis chain
Verify SHA256 checksum against the official release.
Let's confirm the checksum matches the official v4.0 release tarball.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify SHA256 checksum of the source tarball matches the recipe
# Expected: Should output the same checksum as specified in meta.yaml
# Download the tarball and calculate its checksum
curl -sL https://github.com/rgcgithub/regenie/archive/v4.0.tar.gz | sha256sum
Length of output: 399
Script:
#!/bin/bash
# Let's verify the recipe content and source URL pattern first
cat recipes/regenie/meta.yaml
# Then check if there's an official release on GitHub
gh release view rgcgithub/regenie/v4.0 --json assets,tagName,url
Length of output: 2326
Script:
#!/bin/bash
# Let's check if the repository and release exist with correct casing
gh repo view rgcgithub/regenie
# Also check for any releases to verify the correct repository name
gh release list --repo rgcgithub/regenie
# Alternatively, let's check if it's under a different organization
gh repo search "regenie" --owner RGCGITHUB --json nameWithOwner,url
Length of output: 10682
Script:
#!/bin/bash
# Let's verify the checksum of the v4.0 release tarball now that we confirmed it exists
curl -sL https://github.com/rgcgithub/regenie/archive/refs/tags/v4.0.tar.gz | sha256sum
# Also check if the patch is still needed for v4.0
cat recipes/regenie/patches/0015-update-cmakelist.txt-for-v3.6.patch
Length of output: 13941
Update
regenie
: 3.6 → 4.0recipes/regenie
(click to view/edit other files)@rgcgithub
This pull request was automatically generated (see docs).