Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pyopenms as it seems to be compatible with numpy2 #51992

Merged
merged 8 commits into from
Nov 7, 2024
Merged

update pyopenms as it seems to be compatible with numpy2 #51992

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
616ff63
changed numpy pinning to be more flexible
hechth Nov 7, 2024
1056c83
updated build number
hechth Nov 7, 2024
91c770d
trying with generic numpy pin
hechth Nov 7, 2024
b122b34
fix run dep
hechth Nov 7, 2024
987a1c0
fixed zip keys
hechth Nov 7, 2024
9d8a6b0
removed build config
hechth Nov 7, 2024
bcf271d
Merge branch 'master' into update_pyopenms
hechth Nov 7, 2024
f86f615
set upper python limit to <3.13
hechth Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions recipes/pyopenms/conda_build_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ python_impl:
- cpython
numpy:
- 1.23.*
- 1.23.*
- 1.23.*
- 1.26.*
- >=1.23.0
- >=1.23.0
- >=1.26.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: Avoid using >= constraints for numpy to prevent ABI compatibility issues

Using >= constraints for numpy versions is risky as it can lead to ABI compatibility issues. Numpy has strict ABI compatibility requirements, and it's recommended to pin to specific minor versions using the x.* syntax.

Apply this diff to maintain ABI compatibility:

numpy:
  - 1.23.*
-  - >=1.23.0
-  - >=1.23.0
-  - >=1.26.0
+  - 1.23.*
+  - 1.23.*
+  - 1.26.*

Reference: Numpy's binary compatibility policy recommends pinning to specific minor versions to ensure ABI compatibility.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- >=1.23.0
- >=1.23.0
- >=1.26.0
- 1.23.*
- 1.23.*
- 1.26.*
🧰 Tools
🪛 yamllint

[error] 13-13: syntax error: expected chomping or indentation indicators, but found '='

(syntax)

zip_keys:
- python
- python_impl
Expand Down
2 changes: 1 addition & 1 deletion recipes/pyopenms/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ source:

build:
skip: True # [py2k or osx]
number: 0
number: 1
run_exports:
- {{ pin_subpackage("pyopenms", max_pin="x.x") }}

Expand Down
Loading