Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[biobb_mem] update 5.0.0 #51940

Merged
merged 6 commits into from
Nov 12, 2024
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions recipes/biobb_mem/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
{% set name = "biobb_mem" %}
{% set version = "5.0.0" %}

package:
name: '{{ name|lower }}'
version: '{{ version }}'

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: 9637a957e8bf41cc8474133d66fa991bf16ac674064f7283a1153df79349e819

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add the license file path.

The license_file field is empty but the package is Apache licensed. This should point to the LICENSE file in the source distribution.

-  license_file: ''
+  license_file: LICENSE

Also applies to: 44-44

build:
number: 0
noarch: python
script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv"
run_exports:
- {{ pin_subpackage(name, max_pin='x') }}

requirements:
host:
- python >=3.9
- setuptools
- biobb_common ==5.0.0
- lipyphilic ==0.10.0
- ambertools >=22.5
- gromacs ==2018.6
- chap
run:
- python >=3.9
- biobb_common ==5.0.0
- lipyphilic ==0.10.0
- ambertools >=22.5
- gromacs ==2018.6
- chap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Update gromacs dependency to match other biobb packages

The current gromacs 2018.6 version in biobb_mem is significantly outdated compared to other biobb packages in the repository:

  • biobb_analysis uses gromacs >=2022.2
  • biobb_gromacs uses gromacs ==2022.2

Since biobb_mem depends on biobb_common 5.0.0 (latest), it should align with the gromacs versions used by other up-to-date biobb packages. Consider updating to gromacs >=2022.2 to maintain consistency across the biobb ecosystem.

🔗 Analysis chain

Consider updating gromacs dependency.

The recipe pins gromacs to version 2018.6, which is quite old (about 6 years old). Consider updating to a more recent version to benefit from bug fixes, performance improvements, and new features.


Since we cannot directly check conda package versions in the sandbox environment, let me try to verify the gromacs versions through other means.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check available gromacs versions in conda-forge
conda search -c conda-forge gromacs --info

Length of output: 117


Script:

#!/bin/bash
# Search for other gromacs version references in the repository
rg "gromacs.*[0-9]" --type yaml -A 2 -B 2

# Also check if there are any migration or update related files
fd -e yaml -e yml -e md -e txt | xargs rg -l "gromacs"

Length of output: 3251

test:
imports:
- biobb_mem
- biobb_mem.chap
- biobb_mem.lipyphilicBB
- biobb_mem.ambertools

about:
home: https://github.com/bioexcel/biobb_mem
license: Apache Software License
license_family: APACHE
license_file: ''
summary: Biobb_mem is the Biobb module for membrane structure analysis.
description: "# biobb_mem\n\n### Introduction\nBiobb_mem is the Biobb module for membrane structure analysis.\nBiobb (BioExcel building blocks) packages are Python building blocks that\ncreate\
\ new layer of compatibility and interoperability over popular\nbioinformatics tools.\nThe latest documentation of this package can be found in our readthedocs site:\n[latest API documentation](http://biobb_analysis.readthedocs.io/en/latest/).\n\
\n\n### Copyright & Licensing\nThis software has been developed in the [MMB group](http://mmb.irbbarcelona.org) at the [BSC](http://www.bsc.es/) & [IRB](https://www.irbbarcelona.org/) for the [European BioExcel](http://bioexcel.eu/), funded by the European Commission (EU H2020 [823830](http://cordis.europa.eu/projects/823830), EU H2020 [675728](http://cordis.europa.eu/projects/675728)).\
\n\n* (c) 2015-2024 [Barcelona Supercomputing Center](https://www.bsc.es/)\n* (c) 2015-2024 [Institute for Research in Biomedicine](https://www.irbbarcelona.org/)\n\
Licensed under the\n\
[Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0), see the file LICENSE for details.\n\
\n\
![](https://bioexcel.eu/wp-content/uploads/2019/04/Bioexcell_logo_1080px_transp.png \"Bioexcel\")\n\n\n"
doc_url: ''
dev_url: ''
Comment on lines +56 to +57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add documentation and development URLs.

The description mentions readthedocs documentation, but doc_url is empty. Similarly, dev_url should point to the GitHub repository.

-  doc_url: ''
-  dev_url: ''
+  doc_url: 'http://biobb_analysis.readthedocs.io/en/latest/'
+  dev_url: 'https://github.com/bioexcel/biobb_mem'

Committable suggestion skipped: line range outside the PR's diff.


extra:
recipe-maintainers: ''
Comment on lines +59 to +60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add recipe maintainers.

The recipe-maintainers field is empty. This should list the GitHub usernames of people responsible for maintaining this recipe.

-  recipe-maintainers: ''
+  recipe-maintainers:
+    - RubenChM

Committable suggestion skipped: line range outside the PR's diff.

Loading