Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding msa4u #51864

Merged
merged 6 commits into from
Nov 3, 2024
Merged

Adding msa4u #51864

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2e61da3
Adding msa4u
druvus Nov 1, 2024
373d548
Add run_export
druvus Nov 1, 2024
2ffe0c5
Merge branch 'master' into msa4u
druvus Nov 3, 2024
80a9337
Update meta.yaml
druvus Nov 3, 2024
9c2eba5
Update meta.yaml
druvus Nov 3, 2024
8684b16
Fix home url
druvus Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions recipes/msa4u/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{% set name = "msa4u" %}
{% set version = "0.4.0" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/msa4u-{{ version }}.tar.gz
sha256: 0471f334bbc1fbb8ea6c0974c39f9aed59030b32d3d790caf814c8f53c393c17

build:
run_exports:
- {{ pin_subpackage("msa4u", max_pin="x.x") }}
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
noarch: python

requirements:
host:
- python
- pip
run:
- python
- biopython
- pandas
- reportlab
bgruening marked this conversation as resolved.
Show resolved Hide resolved
- configs

test:
imports:
- msa4u
commands:
- msa4u --help

about:
home: https://art-egorov.github.io/msa4u/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Homepage URL is not accessible

The specified homepage URL (https://art-egorov.github.io/msa4u/) returns a 404 error, indicating that the documentation site is not available. Please:

  • Update the homepage URL in recipes/msa4u/meta.yaml to point to a valid, accessible documentation site
  • Consider using the GitHub repository URL as a fallback if a dedicated documentation site is not yet published
🔗 Analysis chain

Verify homepage accessibility.

Let's ensure the documentation homepage is accessible and contains relevant information.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the homepage is accessible
# Expected: Should return a successful status code

# Test: Check homepage availability
curl -sL -w "%{http_code}" "https://art-egorov.github.io/msa4u/" -o /dev/null

Length of output: 81

summary: "A simple visualisation tool for Multiple Sequence Alignment."
license: WTFPL
license_file: LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Consider using a more appropriate license for scientific software

The verification confirms that the package indeed uses the WTFPL license. For scientific software that may be used in academic or research contexts, this license choice raises concerns:

  • Lacks explicit terms for attribution and citation requirements
  • No clear statements about warranties and liability
  • May not meet institutional requirements for software usage
  • Could potentially limit adoption in professional/academic environments

Recommended alternatives:

  • MIT License: Simple, permissive, with clear liability disclaimers
  • BSD License: Well-recognized in academic communities
  • Apache 2.0: Comprehensive coverage of patents and contributions
🔗 Analysis chain

Review license choice for scientific software.

The WTFPL license might not be the most appropriate choice for scientific software as it lacks explicit terms for attribution, warranties, and liability. Consider suggesting a more standard license like MIT, BSD, or Apache 2.0.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check upstream license
# Expected: Should show actual license content from the source

# Test: Look for LICENSE file content in the package
curl -sL "https://raw.githubusercontent.com/art-egorov/msa4u/main/LICENSE"

Length of output: 557

Loading