Add fc-virus recipe #51809
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,7 @@ | ||||||||||||||||||
| #!/bin/bash | ||||||||||||||||||
| set -xe | ||||||||||||||||||
| make CXX="${CXX}" INCLUDES="-I$PREFIX/include" CFLAGS+="${CFLAGS} -g -Wall -O2 -L$PREFIX/lib" | ||||||||||||||||||
| #chmod +x ./bin/fc-virus | ||||||||||||||||||
| chmod 777 ./bin/fc-virus | ||||||||||||||||||
| mkdir -p ${PREFIX}/bin | ||||||||||||||||||
| cp -f ./bin/fc-virus ${PREFIX}/bin | ||||||||||||||||||
|
Comment on lines
+6
to
+7
There was a problem hiding this comment. 🛠️ Refactor suggestion Add error handling for installation steps The installation commands should:
-mkdir -p ${PREFIX}/bin
-cp -f ./bin/fc-virus ${PREFIX}/bin
+if [ ! -f ./bin/fc-virus ]; then
+ echo "Error: fc-virus binary not found" >&2
+ exit 1
+fi
+mkdir -p "${PREFIX}/bin" || exit 1
+install -v -m 755 ./bin/fc-virus "${PREFIX}/bin/" || exit 1📝 Committable suggestion
Suggested change
|
||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| {% set name = "fc" %} | ||
| {% set version = "1.0.1" %} | ||
|
|
||
| package: | ||
| name: {{ name }} | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: "https://github.com/qdu-bioinfo/fc-virus/archive/refs/tags/v{{ version }}.tar.gz" | ||
| sha256: "0f3b5f76ca17c90c7553d35280de6c0248802fad088a7fe653652653e3170944" | ||
|
|
||
| build: | ||
| number: 0 | ||
| skip: True # [osx] | ||
| run_exports: | ||
| - {{ pin_subpackage("fc", max_pin="x") }} | ||
|
|
||
| requirements: | ||
| build: | ||
| - make | ||
| - {{ compiler('c') }} | ||
| - {{ compiler('cxx') }} | ||
| host: | ||
| - zlib | ||
| - boost-cpp | ||
|
|
||
| test: | ||
| commands: | ||
| - fc-virus --help | ||
|
|
||
| about: | ||
| home: "https://github.com/qdu-bioinfo/fc-virus" | ||
| license: MIT | ||
| license_family: MIT | ||
| license_file: LICENSE | ||
| summary: "Accurate Assembly of Full-length Consensus for Viral Quasispecies." | ||
| dev_url: "https://github.com/qdu-bioinfo/fc-virus" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security: Fix overly permissive file permissions
Using chmod 777 grants read/write/execute permissions to all users, which is a security risk. The executable only needs to be executable by users (755).
📝 Committable suggestion