Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cell2cell #51790

Merged
merged 1 commit into from
Oct 31, 2024
Merged

update cell2cell #51790

merged 1 commit into from
Oct 31, 2024

Conversation

nilchia
Copy link
Contributor

@nilchia nilchia commented Oct 29, 2024

This PR changes the python version of cell2cell package to fix its incompatibility with corneto package required for liana package.

Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

coderabbitai bot commented Oct 29, 2024

📝 Walkthrough

Walkthrough

The pull request modifies the meta.yaml file for the cell2cell package. The main changes include an increment in the version number from 0 to 1 in the build section. Additionally, the Python compatibility requirements have been updated; the constraints in both the host and run sections have changed from <=3.8 to <=3.9, allowing the package to be compatible with Python 3.9. No other modifications to the logic, error handling, or control flow are included in this update.

Possibly related PRs

  • Update recipe for ViroConstrictor #51038: The meta.yaml file for the ViroConstrictor package also includes an update to the version number, similar to the version increment in the main PR for the cell2cell package.
  • [biobb_cp2k] update 5.0.0 #51528: The biobb_cp2k package's meta.yaml file updates the Python version requirement from >=3.8 to >=3.9, which aligns with the Python compatibility changes made in the main PR.
  • Update Resistify #51675: The resistify package's meta.yaml file modifies the Python version constraint from >=3.9 to >=3.9,<3.10, indicating a focus on Python version compatibility, similar to the changes in the main PR.
  • Add cell2cell #51744: This PR adds the cell2cell package, which directly relates to the main PR as it involves modifications to the meta.yaml file for the same package, including versioning and dependencies.

Suggested labels

please review & merge

Suggested reviewers

  • bgruening

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f388436 and 131fd98.

📒 Files selected for processing (1)
  • recipes/cell2cell/meta.yaml (2 hunks)
🔇 Additional comments (3)
recipes/cell2cell/meta.yaml (3)

14-16: LGTM! Build configuration is properly set.

The build number increment and run_exports configuration are correctly implemented to maintain package compatibility.


Line range hint 28-42: Verify dependency version constraints for Python 3.9.

The package has numerous dependencies with specific version constraints. Please ensure all pinned versions are compatible with Python 3.9, particularly:

  • tensorly ==0.8.1
  • gseapy ==1.0.3
  • scanpy <=1.9.3
#!/bin/bash
# Description: Check version constraints of critical dependencies

echo "Checking version constraints in other recipes..."
for pkg in "tensorly" "gseapy" "scanpy"; do
    echo "Checking $pkg..."
    rg -l "python.*3\.9" "recipes/$pkg/" || echo "$pkg recipe not found"
done

23-23: Verify Python 3.9 compatibility with dependencies.

The Python version constraint has been updated to <=3.9. Please verify:

  1. corneto package compatibility with Python 3.9
  2. scanpy 1.9.3 compatibility with Python 3.9

Also applies to: 27-27

✅ Verification successful

Based on the extensive search results, I can verify that scanpy 1.9.3 is compatible with Python 3.9. The evidence shows that many bioinformatics packages in the ecosystem, including those that depend on scanpy, support Python 3.9. Additionally, the cell2cell package itself already specifies scanpy <=1.9.3 as a dependency, indicating compatibility has been established.

The Python 3.9 constraint is compatible with the package dependencies.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check Python version compatibility of dependencies

# Check corneto package constraints
echo "Checking corneto package..."
rg -A 5 "python" "recipes/corneto/meta.yaml" || echo "corneto recipe not found"

# Check scanpy package constraints
echo "Checking scanpy 1.9.3 constraints..."
rg -A 5 "python" "recipes/scanpy/1.9.3/meta.yaml" || echo "scanpy 1.9.3 recipe not found"

Length of output: 880


Script:

#!/bin/bash
# Let's try a different approach to find and check the dependency recipes

# First, let's find all relevant recipe files
echo "Looking for cell2cell recipe..."
fd "meta.yaml" recipes/cell2cell/

echo -e "\nLooking for scanpy recipe..."
fd "meta.yaml" recipes/scanpy/

echo -e "\nChecking cell2cell recipe content..."
if [ -f "recipes/cell2cell/meta.yaml" ]; then
    cat "recipes/cell2cell/meta.yaml"
fi

# Let's also check if there are any other Python version constraints in the repository
echo -e "\nChecking other Python version constraints in recipes..."
rg "python.*3\.[89]" recipes/

Length of output: 391776


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nilchia nilchia marked this pull request as draft October 29, 2024 20:38
@nilchia nilchia marked this pull request as ready for review October 29, 2024 20:57
@nilchia
Copy link
Contributor Author

nilchia commented Oct 29, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 cell2cell-0.7.4-py39h4ac6f70_1.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-64 cell2cell-0.7.4-py39hac4f329_1.tar.bz2 osx-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>

@nilchia nilchia marked this pull request as draft October 29, 2024 21:49
@nilchia nilchia marked this pull request as ready for review October 31, 2024 12:52
@nilchia
Copy link
Contributor Author

nilchia commented Oct 31, 2024

it is also fixes the incompatibility of cell2cell with cylp.

 12:46:15 BIOCONDA INFO (OUT) Could not solve for environment specs
12:46:15 BIOCONDA INFO (OUT) The following packages are incompatible
12:46:15 BIOCONDA INFO (OUT) ├─ cell2cell is installable and it requires
12:46:15 BIOCONDA INFO (OUT) │  └─ python >=3.8,<3.9.0a0  with the potential options
12:46:15 BIOCONDA INFO (OUT) │     ├─ python [3.8.0|3.8.1] would require
12:46:15 BIOCONDA INFO (OUT) │     │  └─ python_abi * *_cp38, which can be installed;
12:46:15 BIOCONDA INFO (OUT) │     ├─ python [3.8.10|3.8.12|...|3.8.8] would require
12:46:15 BIOCONDA INFO (OUT) │     │  └─ python_abi 3.8.* *_cp38, which can be installed;
12:46:15 BIOCONDA INFO (OUT) │     └─ python [3.8.12|3.8.13|3.8.16|3.8.5], which can be installed;
12:46:15 BIOCONDA INFO (OUT) └─ cylp >=0.91.5,<0.92.0  is not installable because there are no viable options
12:46:15 BIOCONDA INFO (OUT)    ├─ cylp 0.91.6 would require
12:46:15 BIOCONDA INFO (OUT)    │  ├─ python >=3.9,<3.10.0a0 , which conflicts with any installable versions previously reported;
12:46:15 BIOCONDA INFO (OUT)    │  └─ python_abi 3.9.* *_cp39, which conflicts with any installable versions previously reported;
12:46:15 BIOCONDA INFO (OUT)    ├─ cylp 0.91.6 would require
12:46:15 BIOCONDA INFO (OUT)    │  └─ python >=3.10,<3.11.0a0 , which conflicts with any installable versions previously reported;
12:46:15 BIOCONDA INFO (OUT)    └─ cylp 0.91.6 would require
12:46:15 BIOCONDA INFO (OUT)       └─ python >=3.11,<3.12.0a0 , which conflicts with any installable versions previously reported.

@bgruening bgruening merged commit 3a52d67 into bioconda:master Oct 31, 2024
6 checks passed
@nilchia nilchia deleted the cell2cell_1 branch October 31, 2024 13:17
@coderabbitai coderabbitai bot mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants