-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pbtk to version 3.4.0 #51779
Update pbtk to version 3.4.0 #51779
Conversation
📝 WalkthroughWalkthroughThe pull request introduces updates to the Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (3)recipes/pbtk/meta.yaml (3)
The addition of Line range hint While the package configuration is generally good, consider adding an explicit Example addition: requirements:
run:
# Add runtime dependencies if any Additionally, verify if the package has any specific version requirements for its dependencies.
This is a significant version bump from 3.1.1 to 3.4.0. While the ✅ Verification successfulVersion update appears safe for downstream dependencies Based on the analysis of the meta.yaml file and package structure:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for potential breaking changes by examining release notes and issues
# between versions 3.1.1 and 3.4.0
# Search for release notes or changelog
rg -i -A 5 "changelog|release.*notes|breaking.*changes"
# Search for version-specific discussions or issues
gh issue list -R PacificBiosciences/pbtk --search "3.4.0 in:title,body"
Length of output: 7218 Script: #!/bin/bash
# Let's try to find more information about potential breaking changes by:
# 1. Looking for test files that might indicate API usage
# 2. Checking package dependencies and requirements
# 3. Looking for documentation or README files
# Check meta.yaml for dependencies and requirements
cat recipes/pbtk/meta.yaml
# Look for test files and documentation
fd -t f "test|README|CHANGES|HISTORY|NEWS" recipes/pbtk/
# Search for any imports or API usage patterns
rg -l "from pbtk|import pbtk" recipes/
Length of output: 1034 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@bioconda-bot please fetch artifacts |
Package(s) built are ready for inspection:
|
@@ -26,6 +26,7 @@ extra: | |||
build: | |||
number: 0 | |||
skip: True # [osx] | |||
binary_relocation: False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why this is needed for your packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have had to add this previously to our packages to resolve build issues:
#44388
Update pbtk to version 3.4.0
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.