Update meta.yaml #51687
Update meta.yaml #51687
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/phabox/meta.yaml (2 hunks)
🔇 Additional comments (1)
recipes/phabox/meta.yaml (1)
13-13: LGTM: Build number increment is appropriate.The build number increment is correct as we're adding new dependencies without changing the package version.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
recipes/phabox/meta.yaml (1)
31-39: Fix trailing whitespace.There are trailing spaces at the end of several lines in the requirements section.
🧰 Tools
🪛 yamllint
[error] 31-31: trailing spaces
(trailing-spaces)
[error] 32-32: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 37-37: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 39-39: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/phabox/meta.yaml (2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/phabox/meta.yaml
[error] 31-31: trailing spaces
(trailing-spaces)
[error] 32-32: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 37-37: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 39-39: trailing spaces
(trailing-spaces)
🔇 Additional comments (2)
recipes/phabox/meta.yaml (2)
13-13: LGTM: Build number increment is appropriate.The build number increment is justified due to the dependency updates.
43-45: Verify necessity of PyTorch-related dependencies.The addition of
tritonandacceleratepackages suggests GPU acceleration capabilities, but:
- Are these dependencies essential for core functionality?
- Should they be optional dependencies?
- Does this change the system requirements for users?
Consider moving these to optional dependencies if they're only needed for GPU acceleration.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/phabox/meta.yaml (1)
31-39: Remove trailing spaces.
Several lines contain trailing spaces. While this doesn't affect functionality, it's good practice to maintain clean formatting.
- - fasttree =2.1.11
- - kcounter =0.1.1
- - numpy =1.26.4
- - pandas =2.2.3
- - networkx =3.4.2
- - seaborn-base =0.13.2
- - biopython =1.84
- - tqdm =4.66.5
+ - fasttree =2.1.11
+ - kcounter =0.1.1
+ - numpy =1.26.4
+ - pandas =2.2.3
+ - networkx =3.4.2
+ - seaborn-base =0.13.2
+ - biopython =1.84
+ - tqdm =4.66.5🧰 Tools
🪛 yamllint
[error] 31-31: trailing spaces
(trailing-spaces)
[error] 32-32: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 37-37: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 39-39: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/phabox/meta.yaml (2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/phabox/meta.yaml
[error] 31-31: trailing spaces
(trailing-spaces)
[error] 32-32: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 37-37: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 39-39: trailing spaces
(trailing-spaces)
🔇 Additional comments (4)
recipes/phabox/meta.yaml (4)
13-13: LGTM: Build number increment is appropriate.
The build number increment follows conda packaging best practices for dependency updates without version changes.
27-27: Reiterating previous review comment about Python version constraint.
41-45: Verify ML-related dependencies.
The addition of ML-related dependencies (triton, accelerate) alongside pytorch suggests new machine learning functionality. Please verify:
- Are these dependencies essential for core functionality?
- Could they be made optional to reduce installation size for users who don't need ML features?
28-33: Verify version requirements for bioinformatics tools.
The exact version pinning for tools like BLAST, FastTree, KCounter, and MAFFT might be unnecessarily restrictive. Unless these specific versions are required for compatibility:
- Consider using minimum version constraints (
>=) for tools that maintain backward compatibility - If specific versions are required, please document the reasoning in the recipe
🧰 Tools
🪛 yamllint
[error] 31-31: trailing spaces
(trailing-spaces)
[error] 32-32: trailing spaces
(trailing-spaces)
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.