-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update genmod to 3.9 #51630
Update genmod to 3.9 #51630
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/genmod/meta.yaml (1 hunks)
🔇 Additional comments (2)
recipes/genmod/meta.yaml (2)
2-2
: Version bump looks correct.The version update from 3.8.3 to 3.9 follows semantic versioning, and the build number has been appropriately reset to 0.
Let's verify the version against PyPI:
✅ Verification successful
Let me try a different approach to verify the version information.
Version update to 3.9 is correct and matches PyPI
The version bump from 3.8.3 to 3.9 is accurate as version 3.9 is indeed the latest available version on PyPI, as shown in the version listing. The update follows the proper version sequence and represents the most recent release.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that 3.9 is the latest version on PyPI curl -s https://pypi.org/pypi/genmod/json | jq -r '.info.version'Length of output: 204
Script:
#!/bin/bash # Let's check all available versions on PyPI curl -s https://pypi.org/pypi/genmod/json | jq -r '.releases | keys[]' | sort -VLength of output: 1044
Line range hint
1-67
: Package configuration review.The overall package configuration looks good:
- Maintains Python 3.8.* compatibility
- Dependencies are properly specified
- Build configuration and metadata are correct
- noarch: python is appropriate for this package
However, there's one potential improvement to consider:
Consider updating the Python version constraint to support newer versions (3.9+) if the package is compatible. This would provide more flexibility for users.
Let's check if newer Python versions are supported in the upstream repository:
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
|
||
package: | ||
name: "{{ name|lower }}" | ||
version: "{{ version }}" | ||
|
||
source: | ||
url: "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz" | ||
sha256: 97a411f3f014557cf57aed9cc18e55e097ab7c54b191eb7995c10dd97d4bdeaf | ||
sha256: bbe7ad87971b50f4165142481147738882be96e1200d10dcea79a31d614e0cf2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
SHA256 checksum mismatch detected
The SHA256 checksum in the recipe (bbe7ad87971b50f4165142481147738882be96e1200d10dcea79a31d614e0cf2
) does not match the official PyPI checksum for genmod version 3.9 (328c90f7109ca736d696a838d8f94c51b9f54f0fd9d496abedca3e3ecf11d4a8
).
- The checksum needs to be updated to match the official PyPI release:
328c90f7109ca736d696a838d8f94c51b9f54f0fd9d496abedca3e3ecf11d4a8
🔗 Analysis chain
SHA256 checksum update verified.
The new SHA256 checksum follows the correct format and length.
Let's verify the checksum against PyPI:
Let me gather more information to understand the correct SHA256 value from PyPI.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify SHA256 matches PyPI
curl -s https://pypi.org/pypi/genmod/json | \
jq -r '.releases["3.9"][0].digests.sha256' | \
grep -q "bbe7ad87971b50f4165142481147738882be96e1200d10dcea79a31d614e0cf2" && \
echo "SHA256 matches PyPI" || echo "SHA256 mismatch"
Length of output: 204
Script:
#!/bin/bash
# Get the version and SHA256 from PyPI for genmod package
curl -s https://pypi.org/pypi/genmod/json | \
jq -r '.releases | keys[]' | sort -V # List all available versions
echo "SHA256 for version 3.9:"
curl -s https://pypi.org/pypi/genmod/json | \
jq -r '.releases["3.9"][0].digests' # Show full digest info for 3.9
Length of output: 1396
Update
genmod
: 3.8.3 → 3.9recipes/genmod
(click to view/edit other files)This pull request was automatically generated (see docs).