Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update genmod to 3.9 #51630

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Update genmod to 3.9 #51630

merged 1 commit into from
Oct 24, 2024

Conversation

BiocondaBot
Copy link
Collaborator

Update genmod: 3.8.33.9

install with bioconda Conda

Info Link or Description
Recipe recipes/genmod (click to view/edit other files)
Summary Annotate genetic inheritance models in variant files
Home http://github.com/moonso/genmod
Releases https://pypi.org/pypi/genmod/json
Recipe Maintainer(s) @ramprasadn

This pull request was automatically generated (see docs).

@BiocondaBot BiocondaBot added autobump Automatic Version Update new version labels Oct 24, 2024
Copy link
Contributor

coderabbitai bot commented Oct 24, 2024

📝 Walkthrough

Walkthrough

The pull request modifies the meta.yaml file for the genmod package. The primary change involves updating the package version from "3.8.3" to "3.9". Alongside this version change, the SHA256 checksum for the source tarball is also updated from 97a411f3f014557cf57aed9cc18e55e097ab7c54b191eb7995c10dd97d4bdeaf to bbe7ad87971b50f4165142481147738882be96e1200d10dcea79a31d614e0cf2. The requirements section continues to specify a dependency on Python 3.8, indicating that the package remains compatible with this version. Other dependencies listed in the file are unchanged. The overall structure of the meta.yaml file, which includes sections for package, source, build, requirements, test, about, and extra, remains consistent with previous versions.

Possibly related PRs

  • Update genmod to 3.8.3 #51069: This PR updates the genmod package from version "3.8.2" to "3.8.3", which is directly related to the main PR that updates genmod from "3.8.3" to "3.9". Both PRs involve changes to the same meta.yaml file for the genmod package, specifically updating the version and SHA256 checksum.

Suggested reviewers

  • ramprasadn

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 11ec7d5 and dd76046.

📒 Files selected for processing (1)
  • recipes/genmod/meta.yaml (1 hunks)
🔇 Additional comments (2)
recipes/genmod/meta.yaml (2)

2-2: Version bump looks correct.

The version update from 3.8.3 to 3.9 follows semantic versioning, and the build number has been appropriately reset to 0.

Let's verify the version against PyPI:

✅ Verification successful

Let me try a different approach to verify the version information.


Version update to 3.9 is correct and matches PyPI

The version bump from 3.8.3 to 3.9 is accurate as version 3.9 is indeed the latest available version on PyPI, as shown in the version listing. The update follows the proper version sequence and represents the most recent release.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that 3.9 is the latest version on PyPI
curl -s https://pypi.org/pypi/genmod/json | jq -r '.info.version'

Length of output: 204


Script:

#!/bin/bash
# Let's check all available versions on PyPI
curl -s https://pypi.org/pypi/genmod/json | jq -r '.releases | keys[]' | sort -V

Length of output: 1044


Line range hint 1-67: Package configuration review.

The overall package configuration looks good:

  • Maintains Python 3.8.* compatibility
  • Dependencies are properly specified
  • Build configuration and metadata are correct
  • noarch: python is appropriate for this package

However, there's one potential improvement to consider:

Consider updating the Python version constraint to support newer versions (3.9+) if the package is compatible. This would provide more flexibility for users.

Let's check if newer Python versions are supported in the upstream repository:

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


package:
name: "{{ name|lower }}"
version: "{{ version }}"

source:
url: "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz"
sha256: 97a411f3f014557cf57aed9cc18e55e097ab7c54b191eb7995c10dd97d4bdeaf
sha256: bbe7ad87971b50f4165142481147738882be96e1200d10dcea79a31d614e0cf2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

SHA256 checksum mismatch detected

The SHA256 checksum in the recipe (bbe7ad87971b50f4165142481147738882be96e1200d10dcea79a31d614e0cf2) does not match the official PyPI checksum for genmod version 3.9 (328c90f7109ca736d696a838d8f94c51b9f54f0fd9d496abedca3e3ecf11d4a8).

  • The checksum needs to be updated to match the official PyPI release: 328c90f7109ca736d696a838d8f94c51b9f54f0fd9d496abedca3e3ecf11d4a8
🔗 Analysis chain

SHA256 checksum update verified.

The new SHA256 checksum follows the correct format and length.

Let's verify the checksum against PyPI:


Let me gather more information to understand the correct SHA256 value from PyPI.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify SHA256 matches PyPI
curl -s https://pypi.org/pypi/genmod/json | \
  jq -r '.releases["3.9"][0].digests.sha256' | \
  grep -q "bbe7ad87971b50f4165142481147738882be96e1200d10dcea79a31d614e0cf2" && \
  echo "SHA256 matches PyPI" || echo "SHA256 mismatch"

Length of output: 204


Script:

#!/bin/bash
# Get the version and SHA256 from PyPI for genmod package
curl -s https://pypi.org/pypi/genmod/json | \
  jq -r '.releases | keys[]' | sort -V  # List all available versions

echo "SHA256 for version 3.9:"
curl -s https://pypi.org/pypi/genmod/json | \
  jq -r '.releases["3.9"][0].digests'   # Show full digest info for 3.9

Length of output: 1396

@martin-g martin-g merged commit d7e7b96 into master Oct 24, 2024
7 checks passed
@martin-g martin-g deleted the bump/genmod branch October 24, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump Automatic Version Update new version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants