Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FC-Virus #51578

Closed
wants to merge 1 commit into from
Closed

Create FC-Virus #51578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions recipes/FC-Virus/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package:
name: FC-Virus
version: "1.0.0"

source:
git_url: https://github.com/qdu-bioinfo/FC-Virus
git_tag: main
sha256: a5c91ea315dc7b64b75986128d97c08522aae332cb640fd2c115cc379b4adc51
Comment on lines +5 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Use version tag instead of main branch for reproducibility.

Using git_tag: main is problematic as it:

  1. Makes builds non-reproducible since main branch content can change
  2. Violates conda packaging best practices
  3. Doesn't match the declared version 1.0.0

Consider using a specific version tag (e.g., v1.0.0) that corresponds to the package version.

 source:
   git_url: https://github.com/qdu-bioinfo/FC-Virus
-  git_tag: main
+  git_tag: v1.0.0
   sha256: a5c91ea315dc7b64b75986128d97c08522aae332cb640fd2c115cc379b4adc51

Committable suggestion was skipped due to low confidence.


build:
number: 0
skip: true
Comment on lines +10 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove skip: true to enable package building.

The skip: true setting will prevent the package from being built. This contradicts the PR's purpose of creating a new package.

 build:
   number: 0
-  skip: true
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
build:
number: 0
skip: true
build:
number: 0


requirements:
build:
- gcc
- gxx_linux-64
- make
- boost
run:
- gcc
- boost
Comment on lines +14 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update dependency specifications for better compatibility.

Several improvements needed in the requirements section:

  1. Add compiler pins for gcc/gxx
  2. Specify boost version in build requirements
  3. Replace gcc run dependency with libgcc-ng
  4. Add platform-specific build configuration
 requirements:
   build:
-    - gcc
-    - gxx_linux-64
+    - {{ compiler('c') }}
+    - {{ compiler('cxx') }}
     - make
-    - boost
+    - boost >=1.70.0
   run:
-    - gcc
+    - libgcc-ng  # [linux]
     - boost

Also add platform skip configuration:

build:
  number: 0
  skip: true  # [win]


about:
home: https://github.com/qdu-bioinfo/FC-Virus
license: MIT
summary: "Accurate Assembly of Full-length Consensus for Viral Quasispecies"
run_exports:
- boost >=1.70.0
Comment on lines +24 to +29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Restructure metadata and add license file specification.

  1. Move run_exports section under build
  2. Add license_file field to verify MIT license
 about:
   home: https://github.com/qdu-bioinfo/FC-Virus
   license: MIT
+  license_file: LICENSE
   summary: "Accurate Assembly of Full-length Consensus for Viral Quasispecies"
-  run_exports:
-    - boost >=1.70.0

 build:
   number: 0
+  run_exports:
+    - boost >=1.70.0

Committable suggestion was skipped due to low confidence.


test:
commands:
- ./bin/FC-Virus --help
Comment on lines +31 to +33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Improve test configuration for better validation.

Current test configuration has several issues:

  1. Using relative path ./bin/ won't work in conda environment
  2. Missing version check
  3. No test files or requirements specified
 test:
   commands:
-    - ./bin/FC-Virus --help
+    - FC-Virus --help
+    - FC-Virus --version | grep "1.0.0"
+  requires:
+    - boost >=1.70.0

Committable suggestion was skipped due to low confidence.

Loading