Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nf-core to 3.0.1 #51272

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Update nf-core to 3.0.1 #51272

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a527cc
Update nf-core to 3.0.1
BiocondaBot Oct 9, 2024
8853666
setuptools is no longer pulled in by python?
mencian Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions recipes/nf-core/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% set name = "nf-core" %}
{% set version = "3.0.0" %}
{% set sha256 = "ab67b23840104f7f4125b13519ced9c8021494c03d2eba3f9af6bb3176588846" %}
{% set version = "3.0.1" %}
{% set sha256 = "2ae884ac4d4ff200bd21a69a8c44d4b50e13c16a13474ed570e91955b335c2d7" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

SHA256 checksum is not set correctly.

The sha256 field in recipes/nf-core/meta.yaml is currently set to a placeholder ('{{') instead of the actual checksum value. Please update it with the correct SHA256 checksum for the nf-core 3.0.1 package.

🔗 Analysis chain

SHA256 checksum update looks correct.

The SHA256 checksum has been updated, which is expected for a new package version. However, it's crucial to verify that this checksum corresponds to the correct nf-core 3.0.1 package.

To verify the checksum, you can run the following script:

This script will download the package, calculate its checksum, and compare it with the one in the meta.yaml file.

To address the checksum verification issue, please run the following updated script:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the SHA256 checksum of the nf-core 3.0.1 package

# Download the package
curl -L -o nf_core-3.0.1.tar.gz https://pypi.io/packages/source/n/nf-core/nf_core-3.0.1.tar.gz

# Calculate the SHA256 checksum
calculated_checksum=$(sha256sum nf_core-3.0.1.tar.gz | awk '{print $1}')

# Compare with the checksum in the meta.yaml file
expected_checksum=$(grep 'sha256:' recipes/nf-core/meta.yaml | awk '{print $2}' | tr -d "'")

echo "Calculated checksum: $calculated_checksum"
echo "Expected checksum:   $expected_checksum"

if [ "$calculated_checksum" = "$expected_checksum" ]; then
    echo "Checksum verification successful!"
else
    echo "Checksum verification failed!"
fi

# Clean up
rm nf_core-3.0.1.tar.gz

Length of output: 1131

Script:

# 
#!/bin/bash
# Description: Verify the SHA256 checksum of the nf-core 3.0.1 package using shasum

# Download the package
curl -L -o nf_core-3.0.1.tar.gz https://pypi.io/packages/source/n/nf-core/nf_core-3.0.1.tar.gz

# Calculate the SHA256 checksum using shasum
calculated_checksum=$(shasum -a 256 nf_core-3.0.1.tar.gz | awk '{print $1}')

# Extract the expected checksum from the meta.yaml file
expected_checksum=$(grep 'sha256:' recipes/nf-core/meta.yaml | awk '{print $2}' | tr -d "'\"")

echo "Calculated checksum: $calculated_checksum"
echo "Expected checksum:   $expected_checksum"

if [ "$calculated_checksum" = "$expected_checksum" ]; then
    echo "Checksum verification successful!"
else
    echo "Checksum verification failed!"
fi

# Clean up
rm nf_core-3.0.1.tar.gz

Length of output: 1137


package:
name: {{ name|lower }}
Expand Down
Loading