Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annonars to 0.42.3 #51210

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Update annonars to 0.42.3 #51210

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ac278e7
Update annonars to 0.41.1
BiocondaBot Oct 7, 2024
d51f2d5
clean up recipe
mencian Oct 7, 2024
b4722c2
annonars: Move back protobuf to build deps
martin-g Oct 8, 2024
b1cd29f
annonars: Replace protobuf with libprotobuf (it brings protoc)
martin-g Oct 8, 2024
e578a08
Update annonars to 0.41.2
BiocondaBot Oct 10, 2024
7cae36c
add missing build requirements
tedil Oct 10, 2024
c54c030
skip linux-aarch64 build until rocksdb package has corresponding vers…
tedil Oct 10, 2024
c84f72c
add rocksdb dep to host + run sections as well
tedil Oct 10, 2024
1324ddd
Update annonars to 0.41.3
BiocondaBot Oct 16, 2024
7214e2a
Update annonars to 0.42.0
BiocondaBot Nov 19, 2024
a6fe078
Update annonars to 0.42.1
BiocondaBot Nov 20, 2024
f452f92
Update annonars to 0.42.2
BiocondaBot Nov 20, 2024
dbcb696
Update annonars to 0.42.3
BiocondaBot Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions recipes/annonars/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
#!/bin/bash -e

# TODO: Remove the following export when pinning is updated and we use
# {{ compiler('rust') }} in the recipe.
export \
CARGO_NET_GIT_FETCH_WITH_CLI=true \
CARGO_HOME="${BUILD_PREFIX}/.cargo"

export BINDGEN_EXTRA_CLANG_ARGS="${CFLAGS} ${CPPFLAGS} ${LDFLAGS}"

cargo install --no-track --verbose --root "${PREFIX}" --path .
22 changes: 14 additions & 8 deletions recipes/annonars/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,39 @@
{% set version = "0.41.0" %}
{% set version = "0.42.1" %}

package:
name: annonars
version: {{ version }}

build:
number: 0
skip: True # [osx]
skip: True # [osx]
run_exports:
- {{ pin_subpackage("annonars", max_pin="x.x") }}

source:
url: https://github.com/varfish-org/annonars/archive/refs/tags/v{{ version }}.tar.gz
sha256: 11cf6d760c9a4f5896c5a6883fda2bd39b734862a6acf6af004704edb0752569
sha256: 8ac8774c493cd5a7b2c617d6936cb7a1654026c6402b0a84c85aff3a45a3fb74

requirements:
build:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- rust >=1.30
- clangdev
- {{ compiler('rust') }}
- pkg-config
- protobuf
- make
- cmake
- libprotobuf
- rocksdb
- snappy
host:
Comment on lines +26 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Address RocksDB execution issues

Based on the PR comments, there are execution failures related to using conda-forge's RocksDB package. Consider either:

  1. Compiling RocksDB from source instead of using the conda package
  2. Pinning to a specific working version of RocksDB

Would you like assistance in implementing either of these solutions?

Also applies to: 32-32, 36-36

Comment on lines +25 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: Address RocksDB execution issues

Based on the PR comments, there are execution failures related to using conda-forge's RocksDB package. Consider either:

  1. Compiling RocksDB from source instead of using the conda package
  2. Investigating if specific version constraints on RocksDB and its dependencies (snappy) would resolve the issue

Would you like assistance in implementing either of these solutions?

- clangdev
- libprotobuf
- openssl
- rocksdb
- sqlite
- zlib
run:
- rocksdb
- sqlite

test:
Expand All @@ -39,12 +43,14 @@ test:
about:
home: https://github.com/varfish-org/annonars
license: Apache-2.0
license_family: APACHE
license_file: LICENSE.txt
summary: 'Genome annotation based on Rust and RocksDB.'
dev_url: https://github.com/varfish-org/annonars

extra:
recipe-maintainers:
- holtgrewe
- tedil
additional-platforms:
- linux-aarch64
# additional-platforms:
# - linux-aarch64
Loading