Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_mnv #51178

Merged
merged 13 commits into from
Oct 7, 2024
40 changes: 40 additions & 0 deletions recipes/get_mnv/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{% set name = "get_mnv" %}
{% set version = "1.0.0" %}
{% set sha256 = "a94eda49def81ef76217b8d39095677335945105d581a0cc9b777db4f6f6b014" %}

package:
name: "{{ name|lower }}"
version: "{{ version }}"

source:
url: "https://github.com/PathoGenOmics-Lab/{{ name }}/archive/refs/tags/{{ version }}.tar.gz"
sha256: "{{ sha256 }}"

build:
number: 0
script: "cargo install --no-track --locked --verbose --root \"${PREFIX}\" --path ."

requirements:
build:
- {{ compiler('rust') }}

test:
commands:
- get_mnv --help # Asegúrate de que `get_mnv` sea el nombre del binario
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance test coverage and maintain consistency.

While the current test ensures that the get_mnv binary is installed and executable, consider adding more comprehensive tests to verify the tool's functionality.

  1. Translate the Spanish comment to English for consistency:
-    - get_mnv --help  # Asegúrate de que `get_mnv` sea el nombre del binario
+    - get_mnv --help  # Ensure that `get_mnv` is the correct binary name
  1. Consider adding more test commands to verify key functionalities of the tool. For example:
test:
  commands:
    - get_mnv --help
    - get_mnv --version
    - get_mnv --test-data  # If there's a test data option

Would you like assistance in generating more comprehensive test commands based on the tool's functionality?



about:
home: https://github.com/PathoGenOmics-Lab/get_mnv
license: GLP-3.0
license_file: LICENSE
summary: 'Tool to identify Multi-Nucleotide Variants (MNVs) in genomic sequences.'
description: |
get_MNV is a tool designed to identify Multi-Nucleotide Variants (MNVs) within the same codon in genomic sequences, providing more accurate annotation for genomic data.
doc_url: https://github.com/PathoGenOmics-Lab/get_mnv
dev_url: https://github.com/PathoGenOmics-Lab/get_mnv

extra:
recipe-maintainers:
- PathoGenOmics-Lab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

LGTM: About and extra sections are well-defined, with a minor correction needed.

The about and extra sections provide comprehensive information about the package and its maintenance.

There's a typo in the license field. It should be "GPL-3.0" instead of "GLP-3.0". Please correct this to ensure proper licensing information.

- license: GLP-3.0
+ license: GPL-3.0

Consider adding more specific categories to help users find the tool more easily. You can add a categories field under the extra section. For example:

extra:
  recipe-maintainers:
    - PathoGenOmics-Lab
  categories:
    - Genomics
    - Variant Analysis



Loading