-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dbghaplo #51035
Add dbghaplo #51035
Changes from all commits
414d535
6cb0d19
509d684
8c51acb
08db56d
a193b14
d745937
1a302a1
de2c9f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#!/bin/bash -euo | ||
|
||
# Add workaround for SSH-based Git connections from Rust/cargo. See https://github.com/rust-lang/cargo/issues/2078 for details. | ||
# We set CARGO_HOME because we don't pass on HOME to conda-build, thus rendering the default "${HOME}/.cargo" defunct. | ||
export CARGO_NET_GIT_FETCH_WITH_CLI=true CARGO_HOME="$(pwd)/.cargo" | ||
|
||
# build statically linked binary with Rust | ||
cargo-bundle-licenses --format yaml --output THIRDPARTY.yml | ||
RUST_BACKTRACE=1 cargo install --verbose --locked --no-track --root $PREFIX --path . | ||
cp scripts/* $PREFIX/bin |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
{% set version="0.0.2" %} | ||
|
||
package: | ||
name: dbghaplo | ||
version: {{ version }} | ||
|
||
source: | ||
url: https://github.com/bluenote-1577/dbghaplo/archive/v{{ version }}.tar.gz | ||
sha256: e7e2741afb0c7f12718ec969815d3c8f18ce7ba66517e21c6fcfb3fe4262780b | ||
|
||
build: | ||
number: 0 | ||
run_exports: | ||
- {{ pin_subpackage('dbghaplo', max_pin="x.x") }} | ||
|
||
requirements: | ||
build: | ||
- {{ compiler("cxx") }} | ||
- {{ compiler('rust') }} | ||
- cargo-bundle-licenses | ||
- make | ||
- cmake >=3.12 | ||
run: | ||
- python | ||
- samtools | ||
- minimap2 | ||
- lofreq >=2.1.5 | ||
- tabix | ||
- pysam >=0.16 | ||
Comment on lines
+16
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Consider specifying Python version and adding version constraints for dependencies. The requirements section looks good overall, but there are a few improvements to consider:
Here's a suggested update to the run requirements: run:
- python >=3.6
- samtools >=1.9
- minimap2 >=2.17
- lofreq >=2.1.5
- tabix
- pysam >=0.16 Please adjust the Python version and other tool versions according to your package's specific requirements. 🧰 Tools🪛 yamllint
|
||
|
||
test: | ||
commands: | ||
- dbghaplo -h | ||
- run_dbghaplo_pipeline -h | ||
- haplotag_bam -h | ||
mbhall88 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
about: | ||
home: https://github.com/bluenote-1577/dbghaplo | ||
license: MIT | ||
bluenote-1577 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
license_file: | ||
- LICENSE | ||
- THIRDPARTY.yml | ||
summary: Haplotyping small sequences from heterogeneous long-read sequencing samples with a SNP-encoded positional de Bruijn Graph. | ||
|
||
extra: | ||
recipe-maintainers: | ||
- bluenote-1577 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction needed: Adjust pin_subpackage syntax.
The use of
run_exports
withpin_subpackage
is good for ABI compatibility. However, the syntax forpin_subpackage
is incorrect.Please update the
run_exports
section as follows:Note the single quotes around
'x.x'
and the use of an equals sign instead of a colon.