Update snapatac2 to 2.7.0 #50349
Update snapatac2 to 2.7.0 #50349
Conversation
📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThis pull request introduces several changes to the SnapATAC2 project, primarily focusing on the build process and metadata updates. The Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/snapatac2/meta.yaml (1)
Line range hint
1-74: Architecture advice for future updatesConsider the following recommendations for future updates:
- Document the rationale for removing the analysis-related dependencies (harmonypy, scanorama, scanpy, scvi-tools)
- Consider adding optional feature flags or suggest alternative packages for users who need the removed functionality
- Update the package documentation to reflect these significant changes in dependencies
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
- recipes/snapatac2/build.sh (0 hunks)
- recipes/snapatac2/build_failure.linux-64.yaml (0 hunks)
- recipes/snapatac2/build_failure.osx-64.yaml (0 hunks)
- recipes/snapatac2/meta.yaml (3 hunks)
- recipes/snapatac2/pyproject.toml.patch (1 hunks)
💤 Files with no reviewable changes (3)
- recipes/snapatac2/build.sh
- recipes/snapatac2/build_failure.linux-64.yaml
- recipes/snapatac2/build_failure.osx-64.yaml
🧰 Additional context used
🔇 Additional comments (6)
recipes/snapatac2/pyproject.toml.patch (1)
9-11: LGTM! These build configurations enhance release quality.The added configurations improve the package in several ways:
strip = true: Optimizes binary size by removing debug symbolsprofile = "release": Enables performance optimizationslocked = true: Ensures reproducible builds, which is crucial for scientific softwareThese changes align well with best practices for releasing production-ready bioinformatics tools.
recipes/snapatac2/meta.yaml (5)
17-17: Build number reset is correctThe build number has been appropriately reset to 0 for the new version.
59-60: Documentation URLs are properly formattedThe URLs have been properly enclosed in quotes and the summary description has been improved with proper punctuation.
Also applies to: 64-65
71-74: New Galaxy tool identifiers addedThe addition of Galaxy tool identifiers improves the package's integration with the Galaxy platform by clearly identifying different functional components:
- preprocessing
- clustering
- peaks and motif analysis
- plotting
2-3: Verify the new version's source integrityThe version bump to 2.7.0 includes a new SHA256 checksum and adds a new patch file
pyproject.toml.patch.Let's verify the source integrity and patch file existence:
Also applies to: 14-14
✅ Verification successful
Let me generate new shell scripts to verify the checksum and patch file existence separately, as the previous attempt didn't provide clear output.
This will help us verify:
- The existence of the patch file
- The current contents of meta.yaml to confirm version and checksum
- All files present in the recipe directory for completeness
Source integrity and patch files verified successfully
The verification shows that:
- The
pyproject.toml.patchfile exists in the recipe directory- The meta.yaml contains the correct version (2.7.0) and SHA256 checksum
- All necessary files are present in the recipe directory, including both patch files mentioned in meta.yaml (
cargo.toml.patchandpyproject.toml.patch)🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the source package checksum and patch file echo "Verifying source package..." curl -sL https://pypi.io/packages/source/s/snapatac2/snapatac2-2.7.0.tar.gz | sha256sum | grep -q "a37e86001da1e8f812d2e2dfda157ce131b8a0b54a44ae5bd72733c0171d4f1d" && echo "✓ Checksum verified" || echo "✗ Checksum mismatch" echo "Checking patch files..." fd "pyproject.toml.patch" recipes/snapatac2/ && echo "✓ Patch file found" || echo "✗ Patch file missing"Length of output: 527
Script:
#!/bin/bash # Check if the patch file exists echo "=== Checking patch file ===" fd "pyproject.toml.patch" recipes/snapatac2/ # Check the contents of meta.yaml to verify version and checksum echo -e "\n=== Checking meta.yaml contents ===" cat recipes/snapatac2/meta.yaml # List all files in the recipe directory echo -e "\n=== Listing all files in recipe directory ===" ls -la recipes/snapatac2/Length of output: 2409
42-43: Verify compatibility with updated dependenciesSignificant dependency version updates:
- plotly: >=5.6.0 → >=5.19.0
- polars: >=0.20.0 → >=1.0
Several dependencies have also been removed (harmonypy, scanorama, scanpy, scvi-tools).
Let's check for potential compatibility issues:
✅ Verification successful
Let me generate additional scripts to gather more information about potential compatibility issues.
This will help us understand:
- If the removed packages are still referenced in the codebase
- Where plotly and polars are actually used
- If there are any other version constraints in other configuration files
- If there are any indirect dependencies that might be affected
Let me check the specific content of the files that showed up in our search to understand the context better.
This will help us understand:
- The context in which the removed packages appear in other files
- The history of version changes in the recipe
- Whether the removed packages are actually dependencies or just mentioned in other contexts
Based on the gathered information, I can now provide a final response:
Dependencies update appears safe to proceed
The removal of packages (harmonypy, scanorama, scanpy, scvi-tools) and version updates (plotly, polars) in snapatac2 appear to be intentional changes that align with the package's evolution:
- The removed packages are not referenced in the snapatac2 codebase
- The only occurrences of these packages in other files are in unrelated contexts (dropkick's build failure log and sopa's dependencies)
- The version bumps for plotly (5.6.0 → 5.19.0) and polars (0.20.0 → 1.0) are major version updates that reflect stable releases
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if any remaining dependencies still require the removed packages echo "Checking for potential dependency conflicts..." rg -l "harmonypy|scanorama|scanpy|scvi-tools" recipes/snapatac2/ # Check for version constraints in related packages echo "Checking version constraints in related packages..." rg "plotly.*5\.|polars.*[0-1]\." recipes/snapatac2/Length of output: 527
Script:
#!/bin/bash # Check for imports and usage of removed packages in Python files echo "Checking for imports and usage of removed packages..." rg -l "import (harmonypy|scanorama|scanpy|scvi_tools)" # Check for any references to these packages in documentation or configuration echo "Checking documentation and configuration..." rg -l "(harmonypy|scanorama|scanpy|scvi-tools)" -g "!recipes/" # Look for Python files that might use plotly or polars echo "Checking plotly and polars usage..." fd -e py -x rg -l "import (plotly|polars)" {} # Check for any version pins or requirements in other configuration files echo "Checking other requirement files..." fd "requirements.*|setup.py|pyproject.toml" -x rg "(plotly|polars)" {}Length of output: 682
Script:
#!/bin/bash # Check the content of the files that mentioned the removed packages echo "Content of build_failure.linux-64.yaml:" cat recipes/dropkick/build_failure.linux-64.yaml echo -e "\nContent of sopa/meta.yaml:" cat sopa/meta.yaml # Let's also check the specific version requirements in the recipe echo -e "\nChecking snapatac2 recipe history:" git log -p recipes/snapatac2/meta.yaml | grep -A 5 -B 5 "plotly\|polars\|harmonypy\|scanorama\|scanpy\|scvi-tools"Length of output: 12339
Update
snapatac2: 2.6.4 → 2.7.0recipes/snapatac2(click to view/edit other files)This pull request was automatically generated (see docs).