Update runjob to 2.10.8 #49329
Update runjob to 2.10.8 #49329
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request includes updates to the Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/runjob/meta.yaml (2)
Line range hint
15-15: Consider refactoring batchcompute dependency installationThe current approach of installing batchcompute directly from PyPI URL in the build script is unusual. Consider moving it to the requirements section for better maintainability.
- script: {{ PYTHON }} -m pip install -vvv --no-deps --no-build-isolation . https://pypi.io/packages/source/{{ bc[0] }}/{{ bc }}/{{ bc }}-{{ bcv }}.tar.gz + script: {{ PYTHON }} -m pip install -vvv --no-deps --no-build-isolation . requirements: host: - pip - python >=3.5 + - batchcompute {{ bcv }}🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
Line range hint
24-25: Consider updating minimum Python version requirementPython 3.5 reached end-of-life in September 2020. Consider updating to a more recent version (e.g., >=3.7) for better security and feature support.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/runjob/meta.yaml(2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/runjob/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (1)
recipes/runjob/meta.yaml (1)
1-1: Verify version update integrity
The version bump and checksum update need verification against the upstream repository.
Also applies to: 11-11
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/runjob/meta.yaml (1)
28-28: Consider updating minimum Python version requirementThe current requirement of
python >=3.5seems outdated as Python 3.5 reached end-of-life in September 2020. Consider updating to a more recent minimum version (e.g., >=3.7).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/runjob/meta.yaml(3 hunks)
🧰 Additional context used
🪛 yamllint
recipes/runjob/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (3)
recipes/runjob/meta.yaml (3)
16-16: LGTM! Good optimization for build.
The addition of --no-cache-dir is a good practice for reducing the size of the build environment.
26-26: LGTM! Required for Python package builds.
Adding setuptools to host requirements is correct as it's needed for building Python packages.
1-1: Verify version and checksum
Let's confirm the version exists and the checksum is correct.
Also applies to: 11-11
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
Update
runjob: 2.10.6 → 2.10.8recipes/runjob(click to view/edit other files)@yodengThis pull request was automatically generated (see docs).