-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protestar #47764
base: master
Are you sure you want to change the base?
Add protestar #47764
Conversation
- {{ pin_subpackage('protestar', max_pin='x.x.x') }} | ||
|
||
source: | ||
git_url: https://github.com/refresh-bio/protestar.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use https://github.com/refresh-bio/protestar/archive/refs/tags/v1.1.0.tar.gz + sha256 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
The reason we have used git_url
is the presence of submodules, which are not included in release tarballs. However, as protestar developers, we have a full control on version tags, thus we believe using git_url
is similarly safe as using releases.
We have different problem, though. We use some modern C++ multithreading features that require g++-11 for compilation. Unfortunately, these features are not supported by clang. Therefore, I would like to know if there is some workaround to install g++ in macOS conda environment in order to build a package.
Best Regards,
Adam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be precise, the question about g++ on macOS environment actually concerns some other packages we plan to submit to bioconda, not protestar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could achieve this by using custom conda_build_config.yaml
with contents like:
c_compiler:
- gcc # [linux or osx]
cxx_compiler:
- gxx # [linux or osx]
See https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/a7b5c2d598ef642f911f9a0055ddf92666c6af08/recipe/conda_build_config.yaml for all defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the response! Unfortunately, I got the following message in macOS environment (I have altered also c_compiler_version
and cxx_compiler_version
to 12 so it does not search for g++-16):
10:15:34 BIOCONDA INFO (ERR) The following packages are incompatible
10:15:34 BIOCONDA INFO (ERR) ├─ gcc_osx-64 12.* does not exist (perhaps a typo or a missing channel);
10:15:34 BIOCONDA INFO (ERR) └─ gxx_osx-64 12.* does not exist (perhaps a typo or a missing channel).
Do you have an idea, how to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem actually concerns #49740 pull request.
about: | ||
home: https://github.com/refresh-bio/protestar | ||
summary: "Protein Structures Archiver" | ||
license: GPL-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license: GPL-3 | |
license: GPL-3-only |
Please use SPDX ids
home: https://github.com/refresh-bio/protestar | ||
summary: "Protein Structures Archiver" | ||
license: GPL-3 | ||
license_family: GPL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license_family: GPL | |
license_family: GPL3 |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.