Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bioconductor-rhdf5: rebuild after including libcurl dependency downstream in bioconductor-rhdf5lib, include pin_subpackage syntax #43900

Merged

Conversation

dlaehnemann
Copy link
Member

I think that this will fix an issue with libcrypto.so not being found that I reported over at rhdf5: grimbough/rhdf5#131

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

I think that this will fix an issue with `libcrypto.so` not being found that I reported over at `rhdf5`:
grimbough/rhdf5#131
@dlaehnemann dlaehnemann changed the title fix: [bioconductor-rhdf5] explicitly include libcurl dependency update bioconductor-rhdf5: explicitly include libcurl dependency Oct 26, 2023
@dlaehnemann
Copy link
Member Author

It seems like I missed a number of previous PRs that relate to the same issue. At the time, this was fixed by adding an openssl dependency:

But then, for some reason this was lost again in this bulk PR:
#42063

@dlaehnemann dlaehnemann marked this pull request as draft October 27, 2023 09:02
…hd5flib

This is the PR that handles this:
#43930

And here's the discussion that pinpoints where the libcurl dependency belongs:
grimbough/rhdf5#131 (comment)
@dlaehnemann dlaehnemann changed the title update bioconductor-rhdf5: explicitly include libcurl dependency update bioconductor-rhdf5: rebuild after including libcurl dependency downstream in bioconductor-rhdf5lib, include pin_subpackage syntax Oct 27, 2023
@dlaehnemann
Copy link
Member Author

The libcurl dependency actually belongs downstream in bioconductor-rhdf5lib.

This is the PR that handles this:
#43930

And here's the discussion that pinpoints where the libcurl dependency belongs:
grimbough/rhdf5#131 (comment)

But I'll use this PR to include the pin_subpackage syntax and get a rebuild of the package.

@dlaehnemann
Copy link
Member Author

This is now rebuilt with the latest bioconductor-rhdf5filters and thus the latest bioconductor-rhdf5lib. So this should be fine to merge, if anybody wants to give a quick review.

@dlaehnemann dlaehnemann requested a review from dpryan79 October 29, 2023 19:46
@johanneskoester johanneskoester merged commit d42607b into master Oct 30, 2023
5 checks passed
@johanneskoester johanneskoester deleted the fix-bioconductor-rhdf5-with-explicit-libcurl-dependency branch October 30, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants