Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new recipes for itolapi #21072

Merged
merged 10 commits into from
Mar 26, 2020
Merged

add new recipes for itolapi #21072

merged 10 commits into from
Mar 26, 2020

Conversation

cokelaer
Copy link
Contributor

itolapi new recipes

Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the please review & merge label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it.

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences
    (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

  • @BiocondaBot please update will cause the BiocondaBot to merge the master branch into a PR
  • @BiocondaBot please add label will add the please review & merge label.
  • @BiocondaBot please fetch artifacts will post links to packages and docker containers built by the CI system. You can use this to test packages locally before merging.

For members of the Bioconda project, the following command is also available:

  • @BiocondaBot please merge will cause packages/containers to be uploaded and a PR merged. Someone must approve a PR first! This has the benefit of not wasting CI build time required by manually merging PRs.

If you have questions, please post them in gitter or ping @bioconda/core in a comment (if you are not able to directly ping @bioconda/core then the bot will repost your comment and enable pinging).

@cokelaer cokelaer added the please review & merge set to ask for merge label Mar 24, 2020
@cokelaer
Copy link
Contributor Author

please review & merge this new recipes for atolapi. The python 3.8 was failing and I therefore restricted the build for py3.7 and below

@cokelaer cokelaer requested review from bgruening and chapmanb March 25, 2020 09:09
recipes/itolapi/meta.yaml Outdated Show resolved Hide resolved
@cokelaer cokelaer requested a review from marcelm March 25, 2020 18:54
@cokelaer
Copy link
Contributor Author

@marcelm sorry Marcel, I was not 100% what should have been the proper process. Looking back at the thread, I believed you did propose a change, which is now out-dated. I did not realised I could just accept the changes you made. I incorporated your suggestion myself. sorry about that. What do we do now ? Is the recipe good enough ?

@marcelm
Copy link
Contributor

marcelm commented Mar 25, 2020

I think you did the right thing; I did not not use GitHub’s "propose patch" feature, so you did have to make the change yourself.

recipes/itolapi/meta.yaml Outdated Show resolved Hide resolved
recipes/itolapi/meta.yaml Outdated Show resolved Hide resolved
recipes/itolapi/meta.yaml Outdated Show resolved Hide resolved
recipes/itolapi/meta.yaml Outdated Show resolved Hide resolved
recipes/itolapi/meta.yaml Outdated Show resolved Hide resolved
recipes/itolapi/meta.yaml Outdated Show resolved Hide resolved
recipes/itolapi/meta.yaml Outdated Show resolved Hide resolved
@marcelm
Copy link
Contributor

marcelm commented Mar 26, 2020

The test failure occurs because PyPI is down at the moment. Please remove the restriction to <3.8 again. It is not necessary.

@marcelm
Copy link
Contributor

marcelm commented Mar 26, 2020

Looks good :-)
@BiocondaBot please merge

@cokelaer cokelaer merged commit 9032dd9 into bioconda:master Mar 26, 2020
@cokelaer
Copy link
Contributor Author

@marcelm thanks for all the feedbacks. Very useful. thanks for cutadapt also !

@marcelm
Copy link
Contributor

marcelm commented Mar 26, 2020

You’re welcome :-)

@cokelaer cokelaer deleted the itolapi_recipe branch March 27, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants