Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeatmodeler recipe #19137

Merged
merged 8 commits into from
Dec 13, 2019
Merged

Fix repeatmodeler recipe #19137

merged 8 commits into from
Dec 13, 2019

Conversation

Juke34
Copy link
Contributor

@Juke34 Juke34 commented Dec 6, 2019

Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the please review & merge label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it.

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

  • @BiocondaBot please update will cause the BiocondaBot to merge the master branch into a PR
  • @BiocondaBot please add label will add the please review & merge label.
  • @BiocondaBot please fetch artifacts will post links to packages and docker containers built by the CI system. You can use this to test packages locally before merging.

For members of the Bioconda project, the following command is also available:

  • @BiocondaBot please merge will cause packages/containers to be uploaded and a PR merged. Someone must approve a PR first! This has the benefit of not wasting CI build time required by manually merging PRs.

If you have questions, please post them in gitter or ping @bioconda/core in a comment (if you are not able to directly ping @bioconda/core then the bot will repost your comment and enable pinging).

@Juke34
Copy link
Contributor Author

Juke34 commented Dec 6, 2019

This change should fix the problem with this recipe.

@Juke34
Copy link
Contributor Author

Juke34 commented Dec 6, 2019

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Dec 6, 2019
@marcelm
Copy link
Contributor

marcelm commented Dec 6, 2019

Which problem does this PR address? Why do the current tests not catch that problem? Can you add a test that would fail with the current version of the recipe, but would pass with the change proposed in this PR?

@marcelm
Copy link
Contributor

marcelm commented Dec 6, 2019

If those tests are hard to write then you should at least verify manually that the patch actually fixes the problem. You can use the fetch artifacts command, for example, and then install the revised package locally.

@Juke34
Copy link
Contributor Author

Juke34 commented Dec 9, 2019

Which problem does this PR address?

It has been a while this recipe is not working, it is like an empty shell. The tool seems to run but do not perform anything useful. ie (#9988, Dfam-consortium/RepeatModeler#21, https://www.biostars.org/p/368150/, etc...).

The current test just check actually the main tool compile. But RepeatModeler is a pack of several tools coming with RepatModeler plus several tools from external resources. If one of them fail the pipeline doesn't crash it just skip steps. Depending the crash the output could be empty or not, but we get a file (consensi.fa). The thing is to test the whole pipeline we need to include a data set and run RepeatModeler on it, that could run for hours...

@Juke34
Copy link
Contributor Author

Juke34 commented Dec 9, 2019

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
linux-64 repeatmodeler-1.0.11-pl526_2.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages on linux-64:
conda install -c https://86231-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag Install with docker
repeatmodeler 1.0.11--pl526_2
showcurl "https://86231-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/repeatmodeler%3A1.0.11--pl526_2.tar.gz" | gzip -dc | docker load

@Juke34
Copy link
Contributor Author

Juke34 commented Dec 9, 2019

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
linux-64 repeatmodeler-1.0.11-pl526_2.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages on linux-64:
conda install -c https://86312-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag Install with docker
repeatmodeler 1.0.11--pl526_2
showcurl "https://86312-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/repeatmodeler%3A1.0.11--pl526_2.tar.gz" | gzip -dc | docker load

@Juke34
Copy link
Contributor Author

Juke34 commented Dec 10, 2019

I have added a test now. The test file is 300kb but I cannot make it smaller. The tool needed a fait amount of data to produce a useful output we can check. A least it will avoid to have the problem we got until now where people were trying to use a recipe that was not really working.

@dpryan79
Copy link
Contributor

@bioconda-bot please merge

I'm not overly enthused about a 300kb test file, but it looks like this is the only way currently to prevent regression in this recipe.

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit deac836 into bioconda:master Dec 13, 2019
@Juke34 Juke34 deleted the fix_repeatmodeler branch December 13, 2019 11:30
@oushujun
Copy link
Contributor

oushujun commented Feb 1, 2020

Thanks for fixing this. Has this updated to RepeatModeler2 yet?

@Juke34
Copy link
Contributor Author

Juke34 commented Feb 1, 2020

Not yet... at least not by me.

@jebrosen
Copy link
Contributor

jebrosen commented Feb 1, 2020

I have a bit of a backlog, but updating the RepeatMasker and RepeatModeler recipes is still on my radar.

@oushujun
Copy link
Contributor

oushujun commented Feb 1, 2020

@Juke34 OK that's good to know. I saw your other post (#19805), RECON and RepeatScout is still not available to OSX yet. @jebrosen Are these also on your radar? Thanks guys!

@Juke34
Copy link
Contributor Author

Juke34 commented Feb 5, 2020

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants