-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
easypqp recipe #18701
easypqp recipe #18701
Conversation
In this PR I am trying to add easypqp a new python packaged tool to generate spectral libraries for biological mass spectrometry - proteomics . |
@dpryan79 I think the problem is the current pyopenms depencency on python2. Do you agree? |
Yeah, for some reason I thought pyopenms needed python 2. |
yeah I hope it passes, autowrap apparently has been causing some problems for python3. Thats why I fixed the version 0.19.0 now. |
autowrap 0.19.0 doesn't seem to be available in conda yet. There are some open PRs to update it, I'll see if I can "encourage" them to be merged |
Is it possible to add it? I don't see an autowrap recipe in bioconda |
We just figured, it should work with the 0.18.1 version of autowrap as well. |
autowrap 0.20.0 just got merged in on conda-forge, so if you do end up needing a newer version it's there now. |
for some reason openms 2.4 is still depending on python2 ... |
Should it need python at all? |
I don't think OpenMS should need python. Maybe someone had pyopenms in mind while designing the OpenMS recipe. It seems like Qt is trying to find OpenGL but does not succeed. I am not sure why it is looking for the QtGui target at all when -WITH_GUI=Off is set.. hmm.. In general, @Leon-Bichmann I guess you have to sync your commit with the changes in the openms PR. Otherwise you get into trouble with Xerces and Boost. |
@BiocondaBot update |
@bioconda-bot please update You have to say "please" :) |
@dpryan79 is this ready for a merge? |
@bioconda-bot please fetch artifacts |
Package(s) built on CircleCI are ready for inspection:
You may also use
Docker image(s) built:
|
@bioconda-bot please merge |
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
awesome thx! |
Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the
please review & merge
label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping@bioconda/core
so that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.