Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easypqp recipe #18701

Merged
merged 30 commits into from
Mar 24, 2020
Merged

easypqp recipe #18701

merged 30 commits into from
Mar 24, 2020

Conversation

Leon-Bichmann
Copy link
Contributor

@Leon-Bichmann Leon-Bichmann commented Nov 18, 2019

Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the please review & merge label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping @bioconda/core so that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

@Leon-Bichmann
Copy link
Contributor Author

In this PR I am trying to add easypqp a new python packaged tool to generate spectral libraries for biological mass spectrometry - proteomics .

@Leon-Bichmann Leon-Bichmann mentioned this pull request Nov 18, 2019
5 tasks
@Leon-Bichmann
Copy link
Contributor Author

@dpryan79 I think the problem is the current pyopenms depencency on python2. Do you agree?

@dpryan79
Copy link
Contributor

dpryan79 commented Dec 6, 2019

Yeah, for some reason I thought pyopenms needed python 2.

@Leon-Bichmann
Copy link
Contributor Author

yeah I hope it passes, autowrap apparently has been causing some problems for python3. Thats why I fixed the version 0.19.0 now.

@dpryan79
Copy link
Contributor

dpryan79 commented Dec 6, 2019

autowrap 0.19.0 doesn't seem to be available in conda yet. There are some open PRs to update it, I'll see if I can "encourage" them to be merged

@Leon-Bichmann
Copy link
Contributor Author

Is it possible to add it? I don't see an autowrap recipe in bioconda

@Leon-Bichmann
Copy link
Contributor Author

We just figured, it should work with the 0.18.1 version of autowrap as well.

@dpryan79
Copy link
Contributor

dpryan79 commented Dec 6, 2019

autowrap 0.20.0 just got merged in on conda-forge, so if you do end up needing a newer version it's there now.

@Leon-Bichmann
Copy link
Contributor Author

for some reason openms 2.4 is still depending on python2 ...

@dpryan79
Copy link
Contributor

dpryan79 commented Dec 6, 2019

Should it need python at all?

@jpfeuffer
Copy link
Contributor

I don't think OpenMS should need python. Maybe someone had pyopenms in mind while designing the OpenMS recipe.

It seems like Qt is trying to find OpenGL but does not succeed. I am not sure why it is looking for the QtGui target at all when -WITH_GUI=Off is set.. hmm..

In general, @Leon-Bichmann I guess you have to sync your commit with the changes in the openms PR. Otherwise you get into trouble with Xerces and Boost.

@Leon-Bichmann
Copy link
Contributor Author

@BiocondaBot update

@dpryan79
Copy link
Contributor

@bioconda-bot please update

You have to say "please" :)

@Leon-Bichmann
Copy link
Contributor Author

@dpryan79 is this ready for a merge?

@dpryan79
Copy link
Contributor

@bioconda-bot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
noarch easypqp-0.1.0-py_0.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages on noarch:
conda install -c https://100136-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag Install with docker
easypqp 0.1.0--py_0
showcurl "https://100136-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/easypqp%3A0.1.0--py_0.tar.gz" | gzip -dc | docker load

@dpryan79
Copy link
Contributor

@bioconda-bot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit 9f512f6 into bioconda:master Mar 24, 2020
@Leon-Bichmann
Copy link
Contributor Author

awesome thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants