Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tximport version to 1.12.1. #15813

Merged
merged 4 commits into from
Jun 11, 2019
Merged

Bump tximport version to 1.12.1. #15813

merged 4 commits into from
Jun 11, 2019

Conversation

roryk
Copy link
Contributor

@roryk roryk commented Jun 11, 2019

This version has compatibility for the newly released Salmon 0.14.

Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the please review & merge label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping @bioconda/core so that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

roryk added 2 commits June 11, 2019 16:24
This version has compatibility for the newly released Salmon 0.14.
@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 11, 2019

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
noarch bioconductor-tximport-1.12.1-r351_0.tar.bz2 repodata.json

You may alsu use conda to install these:

  • For packages in noarch:
    conda install -c https://60948-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>
    

Docker image(s) built:

Package Tag Install with docker
bioconductor-tximport 1.12.1--r351_0
showcurl "https://60948-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/bioconductor-tximport%3A1.12.1--r351_0.tar.gz" | gzip -dc | docker load

@roryk roryk added the please review & merge set to ask for merge label Jun 11, 2019
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roryk can you please the linter here? Otherwise, 👍

@roryk
Copy link
Contributor Author

roryk commented Jun 11, 2019

Can do, there isn't a license file though, so that one is going to have to stay.

@roryk
Copy link
Contributor Author

roryk commented Jun 11, 2019

Added an empty license_file line.

@roryk roryk merged commit 17094e7 into bioconda:master Jun 11, 2019
@roryk roryk deleted the update-tximport branch June 11, 2019 22:22
@bgruening
Copy link
Member

@roryk in such cases we are actually forced to ship a GPL file.
But maybe we are lucky here, can you look into license_file: '{{ environ["PREFIX"] }}/lib/R/share/licenses/GPL-3'

kpalin pushed a commit to kpalin/bioconda-recipes that referenced this pull request Aug 7, 2019
* Bump tximport version to 1.12.1.

This version has compatibility for the newly released Salmon 0.14.

* Add myself as a maintainer.

* Shorten summary to make the linter happy.

* Add blank license_file line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants