Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ariba v2.14.0 release #15795

Merged
merged 5 commits into from
Jun 14, 2019
Merged

Ariba v2.14.0 release #15795

merged 5 commits into from
Jun 14, 2019

Conversation

kpepper
Copy link
Contributor

@kpepper kpepper commented Jun 10, 2019

I have read the guidelines for bioconda recipes.
AFAIK, this recipe is directly relevant to the biological sciences
This PR updates an existing recipe.

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 10, 2019

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
linux-64 ariba-2.14.1-py36hf484d3e_0.tar.bz2 repodata.json
osx-64 ariba-2.14.1-py36h0a44026_0.tar.bz2 repodata.json

You may alsu use conda to install these:

  • For packages in linux-64:
    conda install -c https://61111-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>
    
  • For packages in osx-64:
    conda install -c https://61113-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>
    

Docker image(s) built:

Package Tag Install with docker
ariba 2.14.1--py36hf484d3e_0
showcurl "https://61111-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/ariba%3A2.14.1--py36hf484d3e_0.tar.gz" | gzip -dc | docker load

@kpepper kpepper requested a review from druvus June 13, 2019 15:27
Copy link
Member

@epruesse epruesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the missing license_file issue?

Thanks!

@kpepper
Copy link
Contributor Author

kpepper commented Jun 14, 2019

Hi @epruesse. Thanks for the review. As can be seen from my commit comments, I spotted the license file property was missing from the meta.yml, added it in, and then got a Bioconda build failure as the actual file is missing from the PyPI distribution (it is in GitHub). I would need to do another Ariba release to fix it which I just don't have time for at the moment. I have already implemented/tested the change required (see sanger-pathogens/ariba#272) and it will be in the next Ariba release so the issue is resolved, but can you allow it through for this one please?

Copy link
Member

@epruesse epruesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@epruesse
Copy link
Member

@BiocondaBot merge

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 14, 2019

Scheduled Upload & Merge

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 14, 2019

@epruesse, your request to merge failed: Changes have been requested by @{user}

@epruesse
Copy link
Member

@BiocondaBot merge

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 14, 2019

Scheduled Upload & Merge

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 14, 2019

@epruesse, your request to merge failed: Changes have been requested by @{user}

@epruesse
Copy link
Member

Hmm. That's a bug in the bot. Sigh.

@epruesse epruesse merged commit b279f8f into master Jun 14, 2019
@epruesse epruesse deleted the ariba_v2.14.0_branch branch June 14, 2019 15:46
kpalin pushed a commit to kpalin/bioconda-recipes that referenced this pull request Aug 7, 2019
* Updated Ariba meta.yml for v2.14.0 release

* Added license_file property

* Changed Python version selector to try to fix a Bioconda build failure

* Fixed bioconda build issue

* Removed the license file property as caused a build failure. May need to add back in next release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants