-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ariba v2.14.0 release #15795
Ariba v2.14.0 release #15795
Conversation
Package(s) built on CircleCI are ready for inspection:
You may alsu use
Docker image(s) built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the missing license_file
issue?
Thanks!
Hi @epruesse. Thanks for the review. As can be seen from my commit comments, I spotted the license file property was missing from the meta.yml, added it in, and then got a Bioconda build failure as the actual file is missing from the PyPI distribution (it is in GitHub). I would need to do another Ariba release to fix it which I just don't have time for at the moment. I have already implemented/tested the change required (see sanger-pathogens/ariba#272) and it will be in the next Ariba release so the issue is resolved, but can you allow it through for this one please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@BiocondaBot merge |
Scheduled Upload & Merge |
@epruesse, your request to merge failed: Changes have been requested by |
@BiocondaBot merge |
Scheduled Upload & Merge |
@epruesse, your request to merge failed: Changes have been requested by |
Hmm. That's a bug in the bot. Sigh. |
* Updated Ariba meta.yml for v2.14.0 release * Added license_file property * Changed Python version selector to try to fix a Bioconda build failure * Fixed bioconda build issue * Removed the license file property as caused a build failure. May need to add back in next release.
I have read the guidelines for bioconda recipes.
AFAIK, this recipe is directly relevant to the biological sciences
This PR updates an existing recipe.