Adding new recipe (ncbi/TPMcalculator) and bumping igvtools and sra-tools to latest versions #15751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to Bioconda, @r78v10a07! Thank you for opening your first pull request! As you're new to Bioconda, please read through our documentation about contributing recipes. If you need help, please ping one of the following teams:
You can also join our Gitter channel to find help. Please ping If you would like to join Bioconda, please mention that to |
r78v10a07
changed the title
|
In this PR there are two software that needs g++ for its compilation. The meta file include the compiler macros: However, the test failed with error: Both recipes are build correctly in my local Could anyone from @bioconda/lib help, please? |
|
Repeating comment from @r78v10a07 to enable @mention:
|
|
@r78v10a07 The compilers aren't actually named |
|
@BiocondaBot lint |
|
Package(s) built on CircleCI are ready for inspection:
You may alsu use
Docker image(s) built:
|
|
@r78v10a07 As far as I can tell this is good to go (I recall you confirming that remote blast should still work). If that's correct, I'll approve the PR and merge it. BTW, shall I add you to bioconda? |
|
@dpryan79 , I agree that everything is working fine. I tested the packages in OS and Linux and all work fine. |
dpryan79
approved these changes
Jun 12, 2019
kpalin
pushed a commit
to kpalin/bioconda-recipes
that referenced
this pull request
Aug 7, 2019
…ools to latest versions (bioconda#15751) * Adding new version of IGVtools * Updating SRA-Tools to version 2.9.6 * Updating IGVtools build number to 0 * Adding new recipes and moving SRA-tools to the black list due to g++ not found error while testing * Adding new correct compiler to the SRA-tools meta * Changing compiler macro * inject compilers into tpmcalculator * try injecting compilers into ncbi-vdb * Injecting compilers in the sra-tools * Injecting compilers in the sra-tools * Injecting compilers in the sra-tools including the BUILD_PREFIX/bin in the PATH * Injecting compilers in the sra-tools including the BUILD_PREFIX/bin in the PATH * Adding the option to use bundled JDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the
please review & mergelabel so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping@bioconda/coreso that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.