Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump salmon to version 0.14.0 build 1 #15663

Merged
merged 3 commits into from
May 31, 2019
Merged

bump salmon to version 0.14.0 build 1 #15663

merged 3 commits into from
May 31, 2019

Conversation

k3yavi
Copy link
Member

@k3yavi k3yavi commented May 31, 2019

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

@k3yavi k3yavi requested a review from rob-p May 31, 2019 01:58
@k3yavi
Copy link
Member Author

k3yavi commented May 31, 2019

@epruesse It seems the previous PR got auto merge. We were waiting for some last minute changes before #15661 got auto merge . Any idea on how do we make the two PR into one release ?

@epruesse
Copy link
Member

We can't, not unless it's an utter emergency. I'm sorry - I merged that PR. It looked ready to me, and wasn't marked as "Draft" or with the WIP label. What is broken with it?

@rob-p
Copy link
Contributor

rob-p commented May 31, 2019

Well, conda will default to the latest build number anyway, right? So one would need to explicitly request the old version / build combo to get it.

@k3yavi
Copy link
Member Author

k3yavi commented May 31, 2019

No worries @epruesse . Thanks for the reply, it was my bad actually, I should have put a WIP tag or some sort. Nothing major is broken, we found a bug with an optional command line argument at the last minute. As @rob-p said, we will merge this PR then conda can take care of it.

@epruesse
Copy link
Member

If you don't change any dependencies, yes.

Conda has that annoying misfeature (IMO) to prefer a newer version in one package over a newer build in another. That is, if you update a package with stricter pinnings, it likes to use the old build without those pinnings if they require something else be installed with a lower version. Don't like it. Don't see why you'd ever want anything but the newest build,

@epruesse
Copy link
Member

You changed the tag, didn't you? Technically, that's what 0.14.0post1 or 0.14.1 would be for.

@rob-p rob-p merged commit 89921b4 into bioconda:master May 31, 2019
kpalin pushed a commit to kpalin/bioconda-recipes that referenced this pull request Aug 7, 2019
* bumping salmon to v0.14.0

* second build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants