-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t-coffee-12.00.7fb08c2 (build 1) #12601
t-coffee-12.00.7fb08c2 (build 1) #12601
Conversation
pditommaso
commented
Dec 12, 2018
- I have read the guidelines for bioconda recipes.
- This PR adds a new recipe.
- AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- This PR updates an existing recipe.
- This PR does something else (explain below).
Hi, Also tmalign should now be in bioconda, and kalign was merged today and should be in bioconda after successful nightly build. So you can add them as deps. |
because it's the version used by tcoffeee (see here)
Excellent! If you add tmaling remove the one compiled in the build script and the deps on the fortran compiler. |
Well I don't exactly know how the t-coffee access RNAplfold, but there are at least 2 bug-fixes in RNAplfold (2.2.9 and 2.3.2). And the behavior seems to be consistent up to 2.3.4 (which introduced colored output). here |
Yes, but this recipe should use the same package versions used in the upstream tcoffee build for the sake of reproducibility. |
@pditommaso I restarted testing after the rebuilding of problematic dependencies and it seems to work now. |
Excellent! I've pushed another commit to fix the pre-link hook script. |
Not sure to understand why the linting is failing
|
A modification of circleci config got merged in #12662. So you need to merge master into your branch to restart the testing. |
Oops, it should better now. |
No way, now it's failing the pre-link
|
This commit add more deps required by t-coffee.
Nice, all green! Please merge at your convenience. |