Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t-coffee-12.00.7fb08c2 (build 1) #12601

Merged
merged 5 commits into from
Dec 20, 2018
Merged

t-coffee-12.00.7fb08c2 (build 1) #12601

merged 5 commits into from
Dec 20, 2018

Conversation

pditommaso
Copy link
Contributor

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

@SchwarzMarek
Copy link
Contributor

Hi,
may I ask why to fix viennarna to 2.1.9 ?

Also tmalign should now be in bioconda, and kalign was merged today and should be in bioconda after successful nightly build. So you can add them as deps.

@pditommaso
Copy link
Contributor Author

may I ask why to fix viennarna to 2.1.9 ?

because it's the version used by tcoffeee (see here)

Also tmalign should now be in bioconda, and kalign was merged today and should be in bioconda after successful nightly build. So you can add them as deps.

Excellent! If you add tmaling remove the one compiled in the build script and the deps on the fortran compiler.

@SchwarzMarek
Copy link
Contributor

Well I don't exactly know how the t-coffee access RNAplfold, but there are at least 2 bug-fixes in RNAplfold (2.2.9 and 2.3.2). And the behavior seems to be consistent up to 2.3.4 (which introduced colored output). here

@pditommaso
Copy link
Contributor Author

Well I don't exactly know how the t-coffee access RNAplfold, but there are at least 2 bug-fixes in RNAplfold (2.2.9 and 2.3.2)

Yes, but this recipe should use the same package versions used in the upstream tcoffee build for the sake of reproducibility.

@druvus
Copy link
Member

druvus commented Dec 17, 2018

@pditommaso I restarted testing after the rebuilding of problematic dependencies and it seems to work now.

@pditommaso
Copy link
Contributor Author

Excellent! I've pushed another commit to fix the pre-link hook script.

@pditommaso
Copy link
Contributor Author

pditommaso commented Dec 17, 2018

Not sure to understand why the linting is failing

From ssh://github.com/bioconda/bioconda-recipes
 * [new branch]          master     -> __upstream__rZ0o3h9oMI/master
Your bioconda-recipes CI configuration is out of date.
Please update it to the latest version of the upstream master branch.
You can do this, e.g., by running:
  git fetch https://github.com/bioconda/bioconda-recipes.git master
  git merge FETCH_HEAD
Exited with code 1

@druvus
Copy link
Member

druvus commented Dec 17, 2018

A modification of circleci config got merged in #12662. So you need to merge master into your branch to restart the testing.

@pditommaso
Copy link
Contributor Author

Oops, it should better now.

@pditommaso
Copy link
Contributor Author

No way, now it's failing the pre-link

Command '['bash', '-x', '/opt/conda/pkgs/t-coffee-12.00.7fb08c2-h26a2512_1/bin/.t-coffee-pre-link.sh']' returned non-zero exit status 1.

@pditommaso
Copy link
Contributor Author

Nice, all green! Please merge at your convenience.

@apeltzer apeltzer merged commit 90fad72 into bioconda:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants