-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (=really add) Clinker #12472
Fix (=really add) Clinker #12472
Conversation
Update to build as recipe not appearing in bioconda packages
The build log shows "nothing to be done". This still won't build anything. |
Still "nothing to be done". Do not merge. |
Thanks for looking at this @epruesse I'm still unclear what is going on with this recipe. Can you advise on what is preventing this recipe from appearing in bioconda, i.e not available from conda or here https://bioconda.github.io/recipes.html, but appears in the master branch. |
@andrewlonsdale I had this 'nothing to be done' issue, I think it was caused by naming the file meta.yml instead of meta.yaml. |
Aaaah! Thanks @tfursten - that seems to be the case here too. |
You probably have something in the recipe that gets stuck. Your job timed out after 5 hours of processing. |
Recipe now passes local circlei build, mulled-tests and linting, so🤞
Recipe fails locally with build of 2
- samtools | ||
- star ==2.5.3a | ||
- bioconductor-biomart ==2.34.2 | ||
- bioconductor-gviz ==1.22.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need to pin that tightly, you should distribute an environment file. Please make these something like
- star >=2.5.3a, <3
- bioconductor-biomart >=2.34.2, <3
- bioconductor-gviz >=1.22.3, <2
sha256: "5dbb97da27f29f53a8282e456ba0093bbdde292eb9e76405434117da4d1a76be" | ||
|
||
build: | ||
number: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 0 - no packages exist yet.
@@ -0,0 +1,44 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove empty line
@@ -15,8 +15,6 @@ END | |||
) | |||
# Clinker wrapper - invoke bpipe | |||
|
|||
#bpipe -p option1="something" -p option2="something_else" [...] $CLINKERDIR/workflow/clinker.pipe /path/to/*.fastq.gz | |||
# parse and accept parameters in bpipe style, then pass on to fixed clinker.pipe location |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this entire file should be distributed upstream. Can you create a PR there and link it in the recipe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notes: | | ||
Wrapper script provided to indicate clinker is a bpipe pipeline, | ||
provide example command from wiki, and also a passthrough option. | ||
Tests run from /tmp to avoid Docker permission error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to add yourself as recipe-maintainers: [username]
?
This can be closed, #25647 is latest update to recipe and fixes other issues |
These are minor changes intended to trigger the build process again as previous addition of this recipe passed tests and was merged into master (#10244) but the recipe does not appear to be available.