-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump pylibseq #11802
bump pylibseq #11802
Conversation
molpopgen
commented
Nov 6, 2018
- I have read the guidelines for bioconda recipes.
- [x ] This PR adds a new recipe.
- [] AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- This PR updates an existing recipe.
- This PR does something else (explain below).
@bgruening It seems like something odd is happening here. There is a complaint about svgwrite and trying to install via setuptools. But, that doesn't seem write. svgwrite is a dependency of msprime, which is installed in the meta.yaml and svgwrite is in conda-forge. The recipe for msprime does show that svgwrite is a run dependency: https://github.com/conda-forge/msprime-feedstock/blob/master/recipe/meta.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@molpopgen I don't even see where the svgwrite is coming from. Its not your tool that defines a dependency on it, isn't it?
recipes/pylibseq/meta.yaml
Outdated
# If this is a new build for the same version, increment the build | ||
# number. If you do not include this key, it defaults to 0. | ||
number: 2 | ||
number: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll change the build number.
svgwrite is a dependency of msprime, which is a listed dependency of my project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgruening This is the error being reported:
RuntimeError: Setuptools downloading is disabled in conda build. Be sure to add all dependencies in the meta.yaml url=https://pypi.org/simple/svgwrite/
@bgruening Sorry to be a bother, but the Circle CI seems to be running in, well, a circle.... |
circles everywhere :) |
@bgruening @bioconda/core svgwrite is a dependency of msprime, which is in turn a dependency of pylibseq. The relevant section of the meta.yaml for pylibseq is currently:
|
@molpopgen |
Do you think that will matter? This error is occurring even if svgwrite is not listed as a build dependency (you can see previous build logs). svgwrite is being pulled in via marking msprime as a depdendency. |
There is something fishy not in your repo but in msprime etc, this comment does not look good |
@bgruening OK, so if I remove that, we will be back to a failing build. I'll ping the msprime author, who is also the maintainer of the conda-forge recipe. |
@molpopgen you can also create a PR against the conda-forge one if you like. |
@bgruening I think I see the error. msprime lists svgwrite as "install_requires" in setup.py, but not in the "host" field at conda-forge. |
@bgruening I've been in contact with the msprime recipe maintainer, who thinks that some of the problem is due to a massive rebuild taking place on conda-forge. I seem unable to restart failed jobs. I tried following your instructions from here, but I do not have permission it seems? |
I restarted the tests for you. You should have permissions. What do you see on top of circle-cI? |
The "rerun workflow" button is grayed out and says "You need write permissions..." when I mouse over it. When I click the "bioconda-workflow" link, I see nothing obvious about how to restart. I am not logged in to Circle CI in any way--could that be the issue? I've never used it outside of these PRs. |
It does seem to be the logging in issue. I just logged in via GitHub and can now see the restart button is activated. Duh! |
@bgruening This is the puzzling thing from the build log. After building, there is another scan for dependencies. I'm unable to track down why this is happening. Shouldn't all dependency resolution have already happened? In fact, you can see in the CircleCI logs that everything has been installed, including the svgwrite that is being complained about.
|
Just jumping in here --- this is really weird! Very hard to know why the already-installed svgwrite isn't being used. One thing I'm wondering is, do you really need msprime as a build-time dependency? Unless you're compiling against it (which I don't think you can be?) then it should only be needed as a run time dep. Is it worth trying this? I'm still trying to fully sort out the upstream openblas issue, this seems to be related to the interaction between the GSL and numpy dependencies. |
@jeromekelleher --Yes, I think I will try removing the build dependency. Regarding openblas. Conda-forge made an odd decision, IMO. The compile GSL against openblas, but do so by deleting libgslcblas and using a symlink to openblas as a replacement. See here. This "works" but is not how GSL recommend using an alternate blas lib. We ran into issue with this when updating the minimum GSL in bioconda. |
This is what's blocking me on the updated msprime package: |
@jeromekelleher unfortunately removing msprime as a build dependency did not solve the problem |
No idea what's going on here @molpopgen, sorry. |
I think I may remove it as both build and run dependencies. Doing so is
technically correct. There is never an attempted import of msprime except
in one C++ function, and that will error out with an exception if msprime
is not installed, which is correct behavior.
__
Kevin Thornton
Associate Professor
Ecology and Evolutionary Biology
UC Irvine
www.molpopgen.org
github.com/molpopgen
github.com/ThorntonLab
…On Mon, Dec 3, 2018 at 4:08 AM Jerome Kelleher ***@***.***> wrote:
@jeromekelleher <https://github.com/jeromekelleher> unfortunately
removing msprime as a build dependency did not solve the problem
No idea what's going on here @molpopgen <https://github.com/molpopgen>,
sorry.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11802 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGHnH0mlFBodh_h5TrtAnXA2pPw9OU33ks5u1RPsgaJpZM4YRHP4>
.
|
Sounds like a plan. |
Closing. To remove msprime as a dependency, |