Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequana_pipetools to 1.0.6 #42830

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Conversation

BiocondaBot
Copy link
Collaborator

@BiocondaBot BiocondaBot commented Sep 5, 2023

Update sequana_pipetools: 0.9.41.0.6

install with bioconda Conda

Info Link or Description
Recipe recipes/sequana_pipetools (click to view/edit other files)
Summary A set of tools to help building or using Sequana pipelines
Home https://github.com/sequana/sequana_pipetools
Releases https://pypi.org/pypi/sequana_pipetools/json
Recipe Maintainer(s) @cokelaer

This pull request was automatically generated (see docs).

@BiocondaBot BiocondaBot added autobump Automatic Version Update new version labels Sep 5, 2023
@dpryan79
Copy link
Contributor

dpryan79 commented Sep 5, 2023

Missing dependencies: easydev, pykwalify

@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.13.0 Update sequana_pipetools to 0.14.0 Sep 20, 2023
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.14.0 Update sequana_pipetools to 0.14.1 Oct 5, 2023
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.16.6 Update sequana_pipetools to 0.16.7 Dec 21, 2023
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.16.7 Update sequana_pipetools to 0.16.8 Jan 7, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.16.8 Update sequana_pipetools to 0.16.9 Jan 11, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.16.9 Update sequana_pipetools to 0.17.0 Jan 13, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.17.0 Update sequana_pipetools to 0.17.1 Feb 5, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.17.1 Update sequana_pipetools to 0.17.2 Feb 9, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.17.2 Update sequana_pipetools to 0.17.3 Feb 13, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 0.17.3 Update sequana_pipetools to 1.0.0 Mar 29, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 1.0.0 Update sequana_pipetools to 1.0.1 Apr 5, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 1.0.1 Update sequana_pipetools to 1.0.2 Jun 24, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 1.0.2 Update sequana_pipetools to 1.0.3 Aug 23, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 1.0.3 Update sequana_pipetools to 1.0.4 Aug 29, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 1.0.4 Update sequana_pipetools to 1.0.5 Sep 12, 2024
@BiocondaBot BiocondaBot changed the title Update sequana_pipetools to 1.0.5 Update sequana_pipetools to 1.0.6 Oct 17, 2024
Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

📝 Walkthrough

Walkthrough

The pull request introduces significant modifications to the meta.yaml file for the sequana_pipetools package. The version is updated from "0.9.4" to "1.0.6", accompanied by a corresponding SHA256 checksum update. The package name is now in lowercase, and the source URL format has been adjusted to align with the new versioning scheme. In the build section, the script command has been revised to include --no-build-isolation and increased verbosity with -vvv. Entry points for sequana_completion and sequana_slurm_status have been redirected to new script locations. A new run_exports field has been added to pin the subpackage version. The requirements section specifies minimum versions for several dependencies, including the addition of charset-normalizer. The test commands have been simplified. The about section sees a change in the home URL format, an updated license to "BSD-3-Clause," and the inclusion of a new documentation URL. The recipe-maintainers section remains unchanged aside from formatting adjustments.

Possibly related PRs

  • Update meta.yaml for spec2vec #49857: This PR updates the meta.yaml file for the spec2vec package, including changes to the version and SHA256 checksum, similar to the updates made in the main PR for sequana_pipetools.
  • Update: Metabuli 1.0.8 #51030: This PR updates the meta.yaml file for the metabuli package, including a version increment and SHA256 checksum update, paralleling the changes in the main PR.
  • Update sequali to 0.12.0 #51271: This PR updates the meta.yaml file for the sequali package, which includes a version update and SHA256 checksum change, akin to the modifications in the main PR.
  • Update seqfu to 1.22.3 #51410: This PR updates the meta.yaml file for the seqfu package, reflecting a version increment and SHA256 checksum update, similar to the changes in the main PR.

Suggested labels

please review & merge


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
recipes/sequana_pipetools/meta.yaml (1)

47-48: Consider keeping test output visible.

The test commands have been simplified by removing output redirection. While this is generally good, it might hide potential warnings or errors. Consider keeping the output visible or redirecting it to a log file for better debugging capabilities.

Suggestion:

  commands:
    - sequana_completion --help > >(tee -a command_output.log) 2> >(tee -a command_error.log >&2)
    - sequana_slurm_status --help > >(tee -a command_output.log) 2> >(tee -a command_error.log >&2)

This will display the output while also saving it to log files.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0599585 and 7fd7d2e.

📒 Files selected for processing (1)
  • recipes/sequana_pipetools/meta.yaml (1 hunks)
🧰 Additional context used
🔇 Additional comments (6)
recipes/sequana_pipetools/meta.yaml (6)

2-3: LGTM: Package metadata updates look good.

The version has been correctly updated to 1.0.6, and the SHA256 checksum has been updated accordingly. The package name is now in lowercase, which is a best practice for conda recipes.

Also applies to: 6-6


10-11: LGTM: Source URL update is correct.

The source URL has been properly updated to reflect the new version (1.0.6) of the package.


25-41: Requirements updates look good and address PR comments.

  1. The Python version requirement has been appropriately updated to >=3.8.
  2. Specific version requirements for dependencies have been added, which helps ensure compatibility.
  3. The switch from setuptools to poetry-core reflects a change in the build system.
  4. The dependencies mentioned in the PR comment (easydev, pykwalify) are now included, addressing the concern about missing dependencies.

51-55: LGTM: About section updates are beneficial.

The changes in the about section provide more accurate and up-to-date information:

  1. The home URL format has been updated.
  2. The license has been correctly specified as BSD-3-Clause.
  3. A new documentation URL has been added, which is helpful for users.

These updates improve the metadata quality of the package.


1-59: Summary of review for sequana_pipetools update

Overall, the changes in this update are positive and align well with the PR objectives. The package has been updated to version 1.0.6 with appropriate modifications throughout the recipe. Key points:

  1. Package metadata, source URL, and version have been correctly updated.
  2. Build script changes include potential concerns with --no-build-isolation.
  3. Requirements have been updated, addressing the PR comment about missing dependencies.
  4. Test commands have been simplified, but consider keeping output visible for debugging.
  5. About section updates provide more accurate and helpful information.

Main areas requiring attention:

  • Verify that --no-build-isolation doesn't cause dependency conflicts.
  • Consider modifying test commands to preserve output visibility.

Please address these concerns and make any necessary adjustments before merging.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


15-21: Build script changes require attention.

  1. The addition of --no-build-isolation to the build script might cause issues if there are conflicting dependencies. Please ensure this doesn't lead to unexpected behavior.
  2. The -vvv flag increases verbosity, which can be helpful for debugging but may produce excessive output.
  3. Entry point updates seem to reflect changes in the package structure. Verify that these new paths are correct.
  4. The addition of run_exports is good for maintaining version consistency.

To check for potential dependency conflicts, run:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump Automatic Version Update new version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants