Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format GitHub workflow #671

Closed

Conversation

ecalifornica
Copy link
Member

Add black format check Github workflow to pushes and pull requests. Also formats code using black in order to pass check. Most changes look to be differences in output between black and isort, another PR follows to reconfigure isort output.

For more information:
https://black.readthedocs.io/en/stable/integrations/github_actions.html

See also #413

@korikuzma
Copy link
Contributor

We recently added black and Ruff as an action + pre-commit hook. pre-commit is really nice. I think it would be nice to have in biocommons projects.

@reece
Copy link
Member

reece commented Sep 9, 2023

@ecalifornica : make reformat should already do a bunch of this. Were you aware of that? If yes, what's the difference?

Copy link

github-actions bot commented Dec 1, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Dec 1, 2023
Copy link

github-actions bot commented Dec 8, 2023

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Dec 8, 2023
@reece reece removed stale Issue is stale and subject to automatic closing closed-by-stale labels Dec 8, 2023
@reece reece reopened this Dec 8, 2023
Copy link

github-actions bot commented Jan 8, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Jan 8, 2024
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jan 15, 2024
@reece reece reopened this Feb 19, 2024
@reece reece requested a review from a team as a code owner February 19, 2024 17:44
@reece reece added resurrected and removed stale Issue is stale and subject to automatic closing labels Feb 19, 2024
@reece
Copy link
Member

reece commented Feb 19, 2024

This issue was closed by stalebot. It has been reopened to give more time for community review. See biocommons coding guidelines for stale issue and pull request policies. This resurrection is expected to be a one-time event.

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Mar 21, 2024
@ahwagner ahwagner removed the stale Issue is stale and subject to automatic closing label Mar 26, 2024
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Apr 26, 2024
Copy link

github-actions bot commented May 3, 2024

This PR was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-by-stale resurrected stale Issue is stale and subject to automatic closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants