Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show marked as tentative in the plate viewer #136

Closed
OMahoneyM opened this issue Dec 6, 2022 · 3 comments
Closed

Show marked as tentative in the plate viewer #136

OMahoneyM opened this issue Dec 6, 2022 · 3 comments

Comments

@OMahoneyM
Copy link

When a sequence is marked as passed or failed, it's noted in the cycle sequencing plate data and the well color will change to green or red, respectively. Currently, when a sequence is marked as tentative, it isn't recorded in the corresponding cycle sequencing plates. The Reaction State instead shows not run and the well is left white in the viewer. I propose that the the suspect option of Reaction State picklist be co-opted for this and changed to tentative for cycle sequencing plates only (It's still a useful option for PCR plates). It can then use suspect's assigned the yellow/orange color to denote wells marked as tentative.

@jdeck88
Copy link
Member

jdeck88 commented Nov 11, 2023

I will need to schedule a time to go over this operation with someone...
@tweeds volunteers to help me with this

@tweedts
Copy link

tweedts commented Jan 20, 2024

Reviewed with John.
Colors on the cycle sequencing plate viewer are assigned via reaction status in the workflow metadata. E.g. when sequences are marked as passed, the reaction state of a well of the cycle sequencing plate is changed to passed and the well is color-coded green. Likewise for failed.
There is currently no change in workflow reaction state and corresponding plate color when sequences are marked as tentative. But reaction state 'suspect' does not equate to a 'tentative' sequence status (one implies uncertainty in reaction success, the other a sequence needing final review).
Suggest tabling issue for now.

@jdeck88
Copy link
Member

jdeck88 commented Jan 24, 2024

Solved with issue #144

@jdeck88 jdeck88 closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants