-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try out error_prone and write about it in the wiki #492
Labels
Comments
11 tasks
|
binkley
added a commit
that referenced
this issue
Aug 9, 2024
See https://github.com/tbroyer/gradle-errorprone-plugin. Example error below. This error seems bizarre. Our code does not do this: perhaps generated code? ``` > Task :compileJava /home/binkley/src/java/modern-java-practices/src/main/java/demo/ErrorProneSpike.java:24: error: [CollectionIncompatibleType] Argument 'i - 1' should not be passed to this method; its type int is not compatible with its collection's type argument Short s.remove(i - 1); ^ (see https://errorprone.info/bugpattern/CollectionIncompatibleType) 1 error ```
jwlibby
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
and removed
spike
Explore options and questions
labels
Aug 9, 2024
jwlibby
changed the title
[Spike] Try out error_prone
Try out error_prone and write about it in the wiki
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This is part of the #462 epic on plugins for quality.
Note: error_prone is a replacement for the stock JDK
javac
as a plugin to the JDK compilerTry out error_prone and see what you think. When evaluating refer to the questions in #462 and upon completion add your pros and cons for this plugin as a comment to the aforementioned story. Plugin link: error-prone.
error_prone
should fail many of the problems spotted by CodeQL and security/quality plugins, but fail them during compile. This is part of "security/quality in depth": if one tool doesn't catch concerns, another tool might.This is a good topic for the "Going Further" section in Use static analysis. That page does not have more (yet) for folks to do in improving the compilation part of their build.
Note, this problem showed up: https://stackoverflow.com/questions/69439506/no-processor-claimed-any-of-these-annotations
Write about it in the wiki
Look for a badge
The text was updated successfully, but these errors were encountered: