Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Gradle 8 #358

Closed
binkley opened this issue Apr 11, 2023 · 4 comments
Closed

Upgrade to Gradle 8 #358

binkley opened this issue Apr 11, 2023 · 4 comments
Assignees
@binkley
Labels
enhancement New feature or request

Comments

@binkley
Copy link
Owner

binkley commented Apr 11, 2023 •
edited
Loading

Note that "test-sets" plugin used for integration tests relies on removed features available in Gradle 7 and prior:

unbroken-dome/gradle-testsets-plugin#131 (comment)

Part of this issue is to switch to the "jvm-test-suite" plugin:
https://docs.gradle.org/current/userguide/jvm_test_suite_plugin.html
It's not as elegant as "test-sets", so research if there is a 3rd-party plugin that wraps up the work for the new API.
@binkley binkley added the enhancement New feature or request label Apr 11, 2023
@binkley binkley self-assigned this Apr 11, 2023
binkley added a commit that referenced this issue Jul 19, 2023
@binkley
Remove the testsets plugin, use native Gradle
36dcb28 
The very excellent unbroken-dome testsets plugin did the Gradle build
configuration for us.
With Gradle 8, it has stopped working, and held back this project from
upgrading Gradle.

References:
- #358
- unbroken-dome/gradle-testsets-plugin#131
- https://docs.gradle.org/current/userguide/java_testing.html#sec:configuring_java_integration_tests
@binkley binkley mentioned this issue Jul 19, 2023
Merged
@binkley
Copy link
Owner Author

binkley commented Jul 20, 2023

PMD remains a blocker.

@sgammon sgammon mentioned this issue Jan 8, 2024
Closed
@binkley
Copy link
Owner Author

binkley commented Mar 31, 2024

This is now working with Gradle 8.7 and PMD 6.x, and I have a working local build for PMD 7.x with JDK 21.

@binkley
Copy link
Owner Author

binkley commented Mar 31, 2024 •
edited
Loading

@sgammon ☝️
I'm breaking apart your PR into pieces, and getting each one working locally.
Thank you so much!

@binkley binkley closed this as completed Mar 31, 2024
@sgammon
Copy link
Collaborator

sgammon commented Mar 31, 2024

@binkley sounds good! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binkley binkley

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgammon @binkley